Sign upLogin

microting/eform-sdk-dotnet

View on GitHub
Star
eFormCore/Infrastructure/Models/MainElement.cs

Summary

Maintainability
B
6 hrs
Test Coverage

File MainElement.cs has 301 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using System.Collections.Generic;
using System.IO;
using System.Text;
using System.Xml.Serialization;
Severity: Minor
Found in eFormCore/Infrastructure/Models/MainElement.cs - About 3 hrs to fix

    Method DataItemGetAllFromList has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            private List<DataItem> DataItemGetAllFromList(List<Element> elements, List<DataItem> dataItemLst)
        {
            foreach (Element element in elements)
            {
                if (element.GetType() == typeof(DataElement))
    Severity: Minor
    Found in eFormCore/Infrastructure/Models/MainElement.cs - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              public MainElement XmlToClass(string xmlStr)
        {
            try
            {
                byte[] byteArray = Encoding.UTF8.GetBytes(xmlStr);
      Severity: Major
      Found in eFormCore/Infrastructure/Models/MainElement.cs and 1 other location - About 1 hr to fix
      eFormCore/Infrastructure/Models/reply/Response.cs on lines 365..383

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 146.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status