Sign upLogin

microting/eform-sdk-dotnet

View on GitHub
Star
eFormCore/Infrastructure/Models/reply/Response.cs

Summary

Maintainability
F
3 days
Test Coverage

File Response.cs has 341 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using System.Collections.Generic;
using System.IO;
using System.Text;
using System.Xml;
Severity: Minor
Found in eFormCore/Infrastructure/Models/reply/Response.cs - About 4 hrs to fix

    Method XmlToClass has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public Response XmlToClass(string xmlStr)
        {
            try
            {
                ResponseTypes rType = ResponseTypes.Invalid;
    Severity: Major
    Found in eFormCore/Infrastructure/Models/reply/Response.cs - About 3 hrs to fix

      Method XmlToClassUsingXmlDocument has 72 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public Response XmlToClassUsingXmlDocument(string xmlStr)
        {
            try
            {
                ResponseTypes rType = ResponseTypes.Invalid;
      Severity: Major
      Found in eFormCore/Infrastructure/Models/reply/Response.cs - About 2 hrs to fix

        Method JsonToClass has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public Response JsonToClass(string json)
        {
            try
            {
                string value = "";
        Severity: Minor
        Found in eFormCore/Infrastructure/Models/reply/Response.cs - About 1 hr to fix

          Method ClassToXml has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  public string ClassToXml()
        {
            try
            {
                string xmlStr = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" + Environment.NewLine +
          Severity: Minor
          Found in eFormCore/Infrastructure/Models/reply/Response.cs - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            {
                    Check check = new Check
                    {
                        UnitId = t.Locate(checkXmlStr, " unit_id=\"", "\""),
                        Date = t.Locate(checkXmlStr, " date=\"", "\""),
            Severity: Major
            Found in eFormCore/Infrastructure/Models/reply/Response.cs and 1 other location - About 5 hrs to fix
            eFormCore/Infrastructure/Models/reply/Response.cs on lines 121..147

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 341.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                {
                        Check check = new Check
                        {
                            UnitId = t.Locate(rawXml, " unit_id=\"", "\""),
                            Date = t.Locate(rawXml, " date=\"", "\""),
            Severity: Major
            Found in eFormCore/Infrastructure/Models/reply/Response.cs and 1 other location - About 5 hrs to fix
            eFormCore/Infrastructure/Models/reply/Response.cs on lines 222..249

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 341.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (xmlStr.Contains("<Value type="))
                {
                    string subXmlStr = t.Locate(xmlStr, "<Response>", "</Response>").Trim();
                    string valueTypeLower =
                        t.Locate(xmlStr, "Value type=\"", "\"").Trim().ToLower(); //digs out value's type
            Severity: Major
            Found in eFormCore/Infrastructure/Models/reply/Response.cs and 1 other location - About 3 hrs to fix
            eFormCore/Infrastructure/Models/reply/Response.cs on lines 166..199

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 213.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (xmlStr.Contains("<Value type="))
                {
                    string subXmlStr = t.Locate(xmlStr, "<Response>", "</Response>").Trim();
                    string valueTypeLower =
                        t.Locate(xmlStr, "Value type=\"", "\"").Trim().ToLower(); //digs out value's type
            Severity: Major
            Found in eFormCore/Infrastructure/Models/reply/Response.cs and 1 other location - About 3 hrs to fix
            eFormCore/Infrastructure/Models/reply/Response.cs on lines 75..108

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 213.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    private ElementList XmlToClassCheck(string xmlStr)
        {
            try
            {
                byte[] byteArray = Encoding.UTF8.GetBytes(xmlStr);
            Severity: Major
            Found in eFormCore/Infrastructure/Models/reply/Response.cs and 1 other location - About 1 hr to fix
            eFormCore/Infrastructure/Models/MainElement.cs on lines 262..280

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 146.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status