microting/eform-sdk-dotnet

View on GitHub
eFormSDK.Integration.Base.CoreTests/CoreTestUploadedData.cs

Summary

Maintainability
C
7 hrs
Test Coverage

Method Core_UploadedData_UploadedDataRead_DoesReturnOneUploadedDataClass has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        [Test]
        public async Task Core_UploadedData_UploadedDataRead_DoesReturnOneUploadedDataClass()
        {
            // Arrance
            string checksum = "";
Severity: Minor
Found in eFormSDK.Integration.Base.CoreTests/CoreTestUploadedData.cs - About 1 hr to fix

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

            public override async Task DoSetup()
            {
                #region Setup SettingsTableContent
    
                DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
    Severity: Major
    Found in eFormSDK.Integration.Base.CoreTests/CoreTestUploadedData.cs and 6 other locations - About 5 hrs to fix
    eFormSDK.Integration.Base.CoreTests/CoreTestEvent.cs on lines 47..76
    eFormSDK.Integration.Base.CoreTests/CoreTestUnit.cs on lines 51..80
    eFormSDK.Integration.Base.CoreTests/CoreTestWorker.cs on lines 46..75
    eFormSDK.Integration.Case.CoreTests/CoreTestCaseReadAllMedium.cs on lines 52..81
    eFormSDK.Integration.Case.CoreTests/CoreTestCaseReadAllShort.cs on lines 52..81
    eFormSDK.Integration.CheckLists.CoreTests/CoreTesteFormFromXMLLarge.cs on lines 53..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 369.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

                UploadedData dU = new UploadedData
                {
                    CreatedAt = DateTime.UtcNow,
                    UpdatedAt = DateTime.UtcNow,
                    Extension = extension,
    Severity: Major
    Found in eFormSDK.Integration.Base.CoreTests/CoreTestUploadedData.cs and 2 other locations - About 50 mins to fix
    eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestUploadedData.cs on lines 84..98
    eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestUploadedData.cs on lines 131..145

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status