Sign upLogin

microting/eform-sdk-dotnet

View on GitHub
Star
eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestField.cs

Summary

Maintainability
D
2 days
Test Coverage

Method SQL_Check_FieldRead_ReturnsField has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        [Test]
        public async Task SQL_Check_FieldRead_ReturnsField()
        {
            // Arrance
Severity: Minor
Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestField.cs - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            [Test]
        public async Task SQL_Check_FieldRead_ReturnsField()
        {
            // Arrance
    Severity: Major
    Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestField.cs and 1 other location - About 1 day to fix
    eFormSDK.Integration.CheckLists.CoreTests/CoreTestAdvanced.cs on lines 1987..2064

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 859.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

            public override async Task DoSetup()
        {
            #region Setup SettingsTableContent

            DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
    Severity: Major
    Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestField.cs and 3 other locations - About 3 hrs to fix
    eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 50..70
    eFormSDK.Integration.Case.SqlControllerTests/SqlControllerTestCaseReadAllShort.cs on lines 56..78
    eFormSDK.Integration.CheckLists.SqlControllerTests/SqlControllerTestReplyElementy.cs on lines 52..72

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 247.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status