Sign upLogin

microting/eform-sdk-dotnet

View on GitHub
Star
eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestSite.cs

Summary

Maintainability
D
1 day
Test Coverage

File SqlControllerTestSite.cs has 313 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using System.IO;
using System.Linq;
using System.Reflection;
using System.Threading.Tasks;
Severity: Minor
Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestSite.cs - About 3 hrs to fix

    Method SQL_Site_SiteGetAll_DoesReturnAllSites has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            [Test]
        public async Task SQL_Site_SiteGetAll_DoesReturnAllSites()
        {
            // Arrance
    Severity: Major
    Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestSite.cs - About 2 hrs to fix

      Method SQL_Site_SimpleSiteGetAll_DoesReturnSiteList has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              [Test]
        public async Task SQL_Site_SimpleSiteGetAll_DoesReturnSiteList()
        {
            // Arrance
      Severity: Major
      Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestSite.cs - About 2 hrs to fix

        Method SQL_Site_SiteReadSimple_ReadsSite has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                [Test]
        public async Task SQL_Site_SiteReadSimple_ReadsSite()
        {
            // Arrance
        Severity: Minor
        Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestSite.cs - About 1 hr to fix

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                  public override async Task DoSetup()
        {
            DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
            SqlController sql = new SqlController(dbContextHelper);
            await sql.SettingUpdate(Settings.token, "abc1234567890abc1234567890abcdef");
          Severity: Major
          Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestSite.cs and 2 other locations - About 4 hrs to fix
          eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestSiteWorker.cs on lines 26..43
          eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestUnit.cs on lines 27..44

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 276.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  [Test]
        public async Task SQL_Site_SiteCreate_ReturnsSiteId()
        {
            // Arrance
          Severity: Major
          Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestSite.cs and 1 other location - About 1 hr to fix
          eFormSDK.Integration.Tests/SqlControllerTestSite.cs on lines 486..504

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 128.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status