Sign upLogin

microting/eform-sdk-dotnet

View on GitHub
Star
eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestUnit.cs

Summary

Maintainability
D
2 days
Test Coverage

File SqlControllerTestUnit.cs has 358 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using System.IO;
using System.Linq;
using System.Reflection;
using System.Threading.Tasks;
Severity: Minor
Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestUnit.cs - About 4 hrs to fix

    Method SQL_Unit_UnitGetAll_ReturnsAllUnits has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            [Test]
        public async Task SQL_Unit_UnitGetAll_ReturnsAllUnits()
        {
            // Arrance
    Severity: Major
    Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestUnit.cs - About 3 hrs to fix

      Method SQL_Unit_UnitUpdate_UpdatesUnit has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              [Test]
        public async Task SQL_Unit_UnitUpdate_UpdatesUnit()
        {
            // Arrance
      Severity: Major
      Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestUnit.cs - About 2 hrs to fix

        Method SQL_Unit_UnitRead_ReadsUnit has 58 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                [Test]
        public async Task SQL_Unit_UnitRead_ReadsUnit()
        {
            // Arrance
        Severity: Major
        Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestUnit.cs - About 2 hrs to fix

          Method SQL_Unit_UnitDelete_DeletesUnit has 57 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  [Test]
        public async Task SQL_Unit_UnitDelete_DeletesUnit()
        {
            // Arrance
          Severity: Major
          Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestUnit.cs - About 2 hrs to fix

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    public override async Task DoSetup()
        {
            DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
            SqlController sql = new SqlController(dbContextHelper);
            await sql.SettingUpdate(Settings.token, "abc1234567890abc1234567890abcdef");
            Severity: Major
            Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestUnit.cs and 2 other locations - About 4 hrs to fix
            eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestSite.cs on lines 26..43
            eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestSiteWorker.cs on lines 26..43

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 276.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status