Sign upLogin

microting/eform-sdk-dotnet

View on GitHub
Star
eFormSDK.Integration.Tests/SqlControllerTestCheckListValue.cs

Summary

Maintainability
D
2 days
Test Coverage

Method SQL_Check_CheckListValueStatusUpdate_UpdatesCheckListValues has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        [Test]
        public async Task SQL_Check_CheckListValueStatusUpdate_UpdatesCheckListValues()
        {
            // Arrance
            #region Arrance
Severity: Major
Found in eFormSDK.Integration.Tests/SqlControllerTestCheckListValue.cs - About 4 hrs to fix

    Method SQL_Check_CheckListValueStatusRead_ReturnsCheckListValuesStatus has 101 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            [Test]
        public async Task SQL_Check_CheckListValueStatusRead_ReturnsCheckListValuesStatus()
        {
            // Arrance
    Severity: Major
    Found in eFormSDK.Integration.Tests/SqlControllerTestCheckListValue.cs - About 4 hrs to fix

      File SqlControllerTestCheckListValue.cs has 287 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      using eFormCore;
using Microsoft.EntityFrameworkCore;
using NUnit.Framework;
using System;
using System.Collections.Generic;
      Severity: Minor
      Found in eFormSDK.Integration.Tests/SqlControllerTestCheckListValue.cs - About 2 hrs to fix

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

                public override async Task DoSetup()
        {
            #region Setup SettingsTableContent

            DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
        Severity: Major
        Found in eFormSDK.Integration.Tests/SqlControllerTestCheckListValue.cs and 9 other locations - About 2 hrs to fix
        eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 50..67
        eFormSDK.Integration.Tests/SqlControllerTestLanguage.cs on lines 49..66
        eFormSDK.Integration.Tests/SqlControllerTestQuestionSet.cs on lines 49..66
        eFormSDK.Integration.Tests/SqlControllerTestSite.cs on lines 49..66
        eFormSDK.Integration.Tests/SqlControllerTestSiteSurveyConfiguration.cs on lines 49..66
        eFormSDK.Integration.Tests/SqlControllerTestSiteWorker.cs on lines 49..66
        eFormSDK.Integration.Tests/SqlControllerTestSurveyConfiguration.cs on lines 48..65
        eFormSDK.Integration.Tests/SqlControllerTestUnit.cs on lines 49..66
        eFormSDK.Integration.Tests/SqlControllerTestWorker.cs on lines 49..66

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 204.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 11 locations. Consider refactoring.
        Open

                    cases aCase = await testHelpers.CreateCase("caseUId", cl1, DateTime.UtcNow, "custom", DateTime.UtcNow,
                worker, rnd.Next(1, 255), rnd.Next(1, 255),
               site, 66, "caseType", unit, DateTime.UtcNow, 1, worker, Constants.WorkflowStates.Created);
        Severity: Major
        Found in eFormSDK.Integration.Tests/SqlControllerTestCheckListValue.cs and 10 other locations - About 1 hr to fix
        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 172..174
        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 376..378
        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 715..717
        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 872..874
        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 1036..1038
        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 1255..1257
        eFormSDK.Integration.CheckLists.SqlControllerTests/SqlControllerTestCheckListValue.cs on lines 146..148
        eFormSDK.Integration.CheckLists.SqlControllerTests/SqlControllerTestCheckListValue.cs on lines 322..324
        eFormSDK.Integration.CheckLists.SqlControllerTests/SqlControllerTestReplyElementy.cs on lines 168..170
        eFormSDK.Integration.Tests/SqlControllerTestCheckListValue.cs on lines 327..329

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 108.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 11 locations. Consider refactoring.
        Open

                    cases aCase = await testHelpers.CreateCase("caseUId", cl1, DateTime.UtcNow, "custom", DateTime.UtcNow,
                worker, rnd.Next(1, 255), rnd.Next(1, 255),
               site, 66, "caseType", unit, DateTime.UtcNow, 1, worker, Constants.WorkflowStates.Created);
        Severity: Major
        Found in eFormSDK.Integration.Tests/SqlControllerTestCheckListValue.cs and 10 other locations - About 1 hr to fix
        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 172..174
        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 376..378
        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 715..717
        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 872..874
        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 1036..1038
        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 1255..1257
        eFormSDK.Integration.CheckLists.SqlControllerTests/SqlControllerTestCheckListValue.cs on lines 146..148
        eFormSDK.Integration.CheckLists.SqlControllerTests/SqlControllerTestCheckListValue.cs on lines 322..324
        eFormSDK.Integration.CheckLists.SqlControllerTests/SqlControllerTestReplyElementy.cs on lines 168..170
        eFormSDK.Integration.Tests/SqlControllerTestCheckListValue.cs on lines 160..162

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 108.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status