microting/eform-sdk-dotnet

View on GitHub
eFormSDK.Integration.Tests/SqlControllerTestOptions.cs

Summary

Maintainability
C
1 day
Test Coverage

Method options_Update_DoesUpdate has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        [Test]
        public async Task options_Update_DoesUpdate()
        {        
            // Arrange
            #region QuestionSet
Severity: Major
Found in eFormSDK.Integration.Tests/SqlControllerTestOptions.cs - About 3 hrs to fix

    Method options_Delete_DoesDelete has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            [Test]
            public async Task options_Delete_DoesDelete()
            {        
                // Arrange
                #region QuestionSet
    Severity: Major
    Found in eFormSDK.Integration.Tests/SqlControllerTestOptions.cs - About 2 hrs to fix

      Method options_Create_DoesCreate has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              [Test]
              public async Task options_Create_DoesCreate()
              {        
                  // Arrange
                  #region QuestionSet
      Severity: Major
      Found in eFormSDK.Integration.Tests/SqlControllerTestOptions.cs - About 2 hrs to fix

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

                    options option = new options
                    {
                        WeightValue = rnd.Next(1, 255),
                        QuestionId = question.Id,
                        Weight = rnd.Next(1, 255),
        Severity: Major
        Found in eFormSDK.Integration.Tests/SqlControllerTestOptions.cs and 6 other locations - About 1 hr to fix
        eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 153..161
        eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 276..284
        eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 336..344
        eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 468..476
        eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 89..97
        eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 191..199

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

                    options option = new options
                    {
                        WeightValue = rnd.Next(1, 255),
                        QuestionId = question.Id,
                        Weight = rnd.Next(1, 255),
        Severity: Major
        Found in eFormSDK.Integration.Tests/SqlControllerTestOptions.cs and 6 other locations - About 1 hr to fix
        eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 153..161
        eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 276..284
        eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 336..344
        eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 468..476
        eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 191..199
        eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 278..286

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

                    options option = new options
                    {
                        WeightValue = rnd.Next(1, 255),
                        QuestionId = question.Id,
                        Weight = rnd.Next(1, 255),
        Severity: Major
        Found in eFormSDK.Integration.Tests/SqlControllerTestOptions.cs and 6 other locations - About 1 hr to fix
        eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 153..161
        eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 276..284
        eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 336..344
        eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 468..476
        eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 89..97
        eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 278..286

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status