Sign upLogin

microting/eform-sdk-dotnet

View on GitHub
Star
eFormSDK.Integration.Tests/SqlControllerTestSurveyConfiguration.cs

Summary

Maintainability
C
1 day
Test Coverage

Method surveyConfiguration_Update_DoesUpdate has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        [Test]
        public async Task surveyConfiguration_Update_DoesUpdate()
        {
            // Arrange
            Random rnd = new Random();
Severity: Minor
Found in eFormSDK.Integration.Tests/SqlControllerTestSurveyConfiguration.cs - About 1 hr to fix

    Method surveyConfiguration_Delete_DoesDelete has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            [Test]
        public async Task surveyConfiguration_Delete_DoesDelete()
        {
            // Arrange
            Random rnd = new Random();
    Severity: Minor
    Found in eFormSDK.Integration.Tests/SqlControllerTestSurveyConfiguration.cs - About 1 hr to fix

      Method surveyConfiguration_Create_DoesCreate has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              [Test]
        public async Task surveyConfiguration_Create_DoesCreate()
        {
            // Arrange
            Random rnd = new Random();
      Severity: Minor
      Found in eFormSDK.Integration.Tests/SqlControllerTestSurveyConfiguration.cs - About 1 hr to fix

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

                public override async Task DoSetup()
        {
            #region Setup SettingsTableContent

            DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
        Severity: Major
        Found in eFormSDK.Integration.Tests/SqlControllerTestSurveyConfiguration.cs and 9 other locations - About 2 hrs to fix
        eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 50..67
        eFormSDK.Integration.Tests/SqlControllerTestCheckListValue.cs on lines 49..66
        eFormSDK.Integration.Tests/SqlControllerTestLanguage.cs on lines 49..66
        eFormSDK.Integration.Tests/SqlControllerTestQuestionSet.cs on lines 49..66
        eFormSDK.Integration.Tests/SqlControllerTestSite.cs on lines 49..66
        eFormSDK.Integration.Tests/SqlControllerTestSiteSurveyConfiguration.cs on lines 49..66
        eFormSDK.Integration.Tests/SqlControllerTestSiteWorker.cs on lines 49..66
        eFormSDK.Integration.Tests/SqlControllerTestUnit.cs on lines 49..66
        eFormSDK.Integration.Tests/SqlControllerTestWorker.cs on lines 49..66

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 204.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    survey_configurations surveyConfiguration = new survey_configurations
            {
                Name = oldName,
                Stop = DateTime.UtcNow,
                Start = DateTime.UtcNow,
        Severity: Minor
        Found in eFormSDK.Integration.Tests/SqlControllerTestSurveyConfiguration.cs and 1 other location - About 45 mins to fix
        eFormSDK.Integration.Tests/SqlControllerTestSurveyConfiguration.cs on lines 168..176

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    survey_configurations surveyConfiguration = new survey_configurations
            {
                Name = oldName,
                Stop = DateTime.UtcNow,
                Start = DateTime.UtcNow,
        Severity: Minor
        Found in eFormSDK.Integration.Tests/SqlControllerTestSurveyConfiguration.cs and 1 other location - About 45 mins to fix
        eFormSDK.Integration.Tests/SqlControllerTestSurveyConfiguration.cs on lines 122..130

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status