microting/eform-sdk-dotnet

View on GitHub
eFormSDK.Integration.Tests/SqlControllerTestWorker.cs

Summary

Maintainability
F
1 wk
Test Coverage

File SqlControllerTestWorker.cs has 804 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using eFormCore;
using Microsoft.EntityFrameworkCore;
using NUnit.Framework;
using System;
using System.Collections.Generic;
Severity: Major
Found in eFormSDK.Integration.Tests/SqlControllerTestWorker.cs - About 1 day to fix

    Method SQL_Worker_WorkerGetAll_ReturnsAllWorkers has 158 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            [Test]
            public async Task SQL_Worker_WorkerGetAll_ReturnsAllWorkers()
            {
                // Arrance
                #region Arrance
    Severity: Major
    Found in eFormSDK.Integration.Tests/SqlControllerTestWorker.cs - About 6 hrs to fix

      Method SQL_Worker_WorkerRead_ReadsWorker has 137 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              [Test]
              public async Task SQL_Worker_WorkerRead_ReadsWorker()
              {
                  // Arrance
                  #region Arrance
      Severity: Major
      Found in eFormSDK.Integration.Tests/SqlControllerTestWorker.cs - About 5 hrs to fix

        Method SQL_Worker_WorkerNameRead_ReadsName has 136 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                [Test]
                public async Task SQL_Worker_WorkerNameRead_ReadsName()
                {
                    // Arrance
                    #region Arrance
        Severity: Major
        Found in eFormSDK.Integration.Tests/SqlControllerTestWorker.cs - About 5 hrs to fix

          Method SQL_Worker_WorkerDelete_DeletesWorker has 136 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  [Test]
                  public async Task SQL_Worker_WorkerDelete_DeletesWorker()
                  {
                      // Arrance
                      #region Arrance
          Severity: Major
          Found in eFormSDK.Integration.Tests/SqlControllerTestWorker.cs - About 5 hrs to fix

            Method SQL_Worker_WorkerUpdate_UpdatesWorker has 136 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    [Test]
                    public async Task SQL_Worker_WorkerUpdate_UpdatesWorker()
                    {
                        // Arrance
                        #region Arrance
            Severity: Major
            Found in eFormSDK.Integration.Tests/SqlControllerTestWorker.cs - About 5 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      [Test]
                      public async Task SQL_Worker_WorkerDelete_DeletesWorker()
                      {
                          // Arrance
                          #region Arrance
              Severity: Major
              Found in eFormSDK.Integration.Tests/SqlControllerTestWorker.cs and 1 other location - About 4 days to fix
              eFormSDK.Integration.Tests/SqlControllerTestSiteWorker.cs on lines 814..1058

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 2117.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 10 locations. Consider refactoring.
              Open

                      public override async Task DoSetup()
                      {
                          #region Setup SettingsTableContent
              
                          DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
              Severity: Major
              Found in eFormSDK.Integration.Tests/SqlControllerTestWorker.cs and 9 other locations - About 2 hrs to fix
              eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 50..67
              eFormSDK.Integration.Tests/SqlControllerTestCheckListValue.cs on lines 49..66
              eFormSDK.Integration.Tests/SqlControllerTestLanguage.cs on lines 49..66
              eFormSDK.Integration.Tests/SqlControllerTestQuestionSet.cs on lines 49..66
              eFormSDK.Integration.Tests/SqlControllerTestSite.cs on lines 49..66
              eFormSDK.Integration.Tests/SqlControllerTestSiteSurveyConfiguration.cs on lines 49..66
              eFormSDK.Integration.Tests/SqlControllerTestSiteWorker.cs on lines 49..66
              eFormSDK.Integration.Tests/SqlControllerTestSurveyConfiguration.cs on lines 48..65
              eFormSDK.Integration.Tests/SqlControllerTestUnit.cs on lines 49..66

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 204.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      [Test]
                      public async Task SQL_Worker_WorkerCreate_ReturnsWorkerId()
                      {
                          // Arrance
              
              
              Severity: Major
              Found in eFormSDK.Integration.Tests/SqlControllerTestWorker.cs and 1 other location - About 1 hr to fix
              eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestWorker.cs on lines 333..347

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 134.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status