Sign upLogin

microting/eform-sdk-dotnet

View on GitHub
Star

Showing 3,203 of 3,219 total issues

File CoreTestFolders.cs has 551 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Reflection;
Severity: Major
Found in eFormSDK.Integration.Base.CoreTests/CoreTestFolders.cs - About 1 day to fix

    Method ReadFieldValue has 230 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            private async Task<Models.FieldValue> ReadFieldValue(MicrotingDbContext db, FieldValue reply, Field dbField, bool joinUploadedData,
            Language language)
        {
            string methodName = "SqlController.ReadFieldValue";
            try
    Severity: Major
    Found in eFormCore/Infrastructure/SqlController.cs - About 1 day to fix

      Method Up has 226 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              protected override void Up(MigrationBuilder migrationBuilder)
        {
            migrationBuilder.RenameTable(
                name: "answer_value_versions",
                null,
      Severity: Major
      Found in eFormCore/Migrations/20201222125152_HugheTableRenaming.cs - About 1 day to fix

        File CasesUTest.cs has 542 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.EntityFrameworkCore;
        Severity: Major
        Found in eFormSDK.CheckLists.Tests/CasesUTest.cs - About 1 day to fix

          Method FieldValues_Delete_DoesSetWorkflowStateToRemoved has 223 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  [Test]
        public async Task FieldValues_Delete_DoesSetWorkflowStateToRemoved()
        {
            short shortMinValue = Int16.MinValue;
            short shortmaxValue = Int16.MaxValue;
          Severity: Major
          Found in eFormSDK.CheckLists.Tests/FieldValuesUTest.cs - About 1 day to fix

            Method SettingCreate has 219 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    public async Task<bool> SettingCreate(Settings name)
        {
            await using var db = GetContext();
            //key point
            // Id = settings.name
            Severity: Major
            Found in eFormCore/Infrastructure/SqlController.cs - About 1 day to fix

              Method DbSetup has a Cognitive Complexity of 71 (exceeds 20 allowed). Consider refactoring.
              Open

                      public async Task<string> DbSetup(string token)
        {
            // try
            // {
            DbContextHelper dbContextHelper = new DbContextHelper(connectionString);
              Severity: Minor
              Found in eFormCore/AdminTools.cs - About 1 day to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          migrationBuilder.CreateTable(
                name: "uploaded_data",
                columns: table => new
                {
                    Id = table.Column<int>(type: "int", nullable: false)
              Severity: Major
              Found in eFormCore/Migrations/20201220194822_FixingTableColumnNames.cs and 1 other location - About 1 day to fix
              eFormCore/Migrations/20201222125152_HugheTableRenaming.cs on lines 1621..1645

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 551.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          migrationBuilder.CreateTable(
                name: "uploaded_datas",
                columns: table => new
                {
                    Id = table.Column<int>(type: "int", nullable: false)
              Severity: Major
              Found in eFormCore/Migrations/20201222125152_HugheTableRenaming.cs and 1 other location - About 1 day to fix
              eFormCore/Migrations/20201220194822_FixingTableColumnNames.cs on lines 65..89

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 551.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Consider simplifying this complex logical expression.
              Open

                                  if (searchKey.Contains("!"))
                    {
                        searchKey = searchKey.ToLower().Replace("!", "");
                        IQueryable<Case> excludeQuery = db.Cases.AsNoTracking().Where(x =>
                            x.DoneAtUserModifiable > start && x.DoneAtUserModifiable < end);
              Severity: Critical
              Found in eFormCore/Infrastructure/SqlController.cs - About 1 day to fix

                Method Down has 216 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        protected override void Down(MigrationBuilder migrationBuilder)
        {
            migrationBuilder.DropForeignKey(
                name: "FK_folders_folders_parentId",
                table: "folders");
                Severity: Major
                Found in eFormCore/Migrations/20190509074123_RefactoringidtoId.cs - About 1 day to fix

                  Method Fields_Create_DoesCreate has 215 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          [Test]
        public async Task Fields_Create_DoesCreate()
        {
            short shortMinValue = Int16.MinValue;
            short shortmaxValue = Int16.MaxValue;
                  Severity: Major
                  Found in eFormSDK.CheckLists.Tests/FieldsUTest.cs - About 1 day to fix

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                                Field field = new Field
            {
                Color = Guid.NewGuid().ToString(),
                Custom = Guid.NewGuid().ToString(),
                Description = Guid.NewGuid().ToString(),
                    Severity: Major
                    Found in eFormSDK.CheckLists.Tests/FieldsUTest.cs and 2 other locations - About 1 day to fix
                    eFormSDK.CheckLists.Tests/FieldsUTest.cs on lines 151..185
                    eFormSDK.CheckLists.Tests/FieldsUTest.cs on lines 389..423

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 542.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                                Field field = new Field
            {
                Color = Guid.NewGuid().ToString(),
                Custom = Guid.NewGuid().ToString(),
                Description = Guid.NewGuid().ToString(),
                    Severity: Major
                    Found in eFormSDK.CheckLists.Tests/FieldsUTest.cs and 2 other locations - About 1 day to fix
                    eFormSDK.CheckLists.Tests/FieldsUTest.cs on lines 389..423
                    eFormSDK.CheckLists.Tests/FieldsUTest.cs on lines 726..760

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 542.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                                Field field = new Field
            {
                Color = Guid.NewGuid().ToString(),
                Custom = Guid.NewGuid().ToString(),
                Description = Guid.NewGuid().ToString(),
                    Severity: Major
                    Found in eFormSDK.CheckLists.Tests/FieldsUTest.cs and 2 other locations - About 1 day to fix
                    eFormSDK.CheckLists.Tests/FieldsUTest.cs on lines 151..185
                    eFormSDK.CheckLists.Tests/FieldsUTest.cs on lines 726..760

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 542.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method GetDataItem has 212 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            private async Task GetDataItem(List<DataItem> lstDataItem, List<DataItemGroup> lstDataItemGroup, Field field,
            Language language, bool includeDummyFields)
        {
            string methodName = "SqlController.GetDataItem";
            try
                    Severity: Major
                    Found in eFormCore/Infrastructure/SqlController.cs - About 1 day to fix

                      Method SQL_Template_TemplateItemReadAll_DoesSortAccordingly has 211 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              [Test]
        public async Task SQL_Template_TemplateItemReadAll_DoesSortAccordingly()
        {
            // Arrance
                      Severity: Major
                      Found in eFormSDK.Integration.Case.SqlControllerTests/SqlControllerTestCaseReadAllShort.cs - About 1 day to fix

                        Method Up has 211 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                protected override void Up(MigrationBuilder migrationBuilder)
        {
            migrationBuilder.CreateIndex(
                name: "IX_survey_configuration_versions_surveyConfigurationId",
                table: "survey_configuration_versions",
                        Severity: Major
                        Found in eFormCore/Migrations/20190319130214_AddingMissingForeignKeys.cs - About 1 day to fix

                          File ReportHelper.cs has 518 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
using System.Linq;
                          Severity: Major
                          Found in eFormCore/Helpers/ReportHelper.cs - About 1 day to fix

                            Similar blocks of code found in 6 locations. Consider refactoring.
                            Open

                                        Field parentFIeld = new Field
            {
                Color = Guid.NewGuid().ToString(),
                Custom = Guid.NewGuid().ToString(),
                Description = Guid.NewGuid().ToString(),
                            Severity: Major
                            Found in eFormSDK.CheckLists.Tests/FieldsUTest.cs and 5 other locations - About 1 day to fix
                            eFormSDK.CheckLists.Tests/FieldValuesUTest.cs on lines 114..147
                            eFormSDK.CheckLists.Tests/FieldValuesUTest.cs on lines 346..379
                            eFormSDK.CheckLists.Tests/FieldValuesUTest.cs on lines 616..649
                            eFormSDK.CheckLists.Tests/FieldsUTest.cs on lines 115..148
                            eFormSDK.CheckLists.Tests/FieldsUTest.cs on lines 353..386

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 535.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Severity
                            Category
                            Status
                            Source
                            Language