Sign upLogin

microting/eform-sdk-dotnet

View on GitHub
Star

Showing 3,203 of 3,219 total issues

Method ClearDb has 94 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        private async Task ClearDb()
        {
            List<string> modelNames = new List<string>
            {
                "CaseVersions",
Severity: Major
Found in eFormSDK.Integration.Case.SqlControllerTests/DbTestFixture.cs - About 3 hrs to fix

    Method ClearDb has 94 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            private async Task ClearDb()
        {
            List<string> modelNames = new List<string>
            {
                "CaseVersions",
    Severity: Major
    Found in eFormSDK.Integration.CheckLists.SqlControllerTests/DbTestFixture.cs - About 3 hrs to fix

      Method ClearDb has 94 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              private async Task ClearDb()
        {
            List<string> modelNames = new List<string>
            {
                "CaseVersions",
      Severity: Major
      Found in eFormSDK.CheckLists.Tests/DbTestFixture.cs - About 3 hrs to fix

        Method ClearDb has 94 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                private async Task ClearDb()
        {
            List<string> modelNames = new List<string>
            {
                "CaseVersions",
        Severity: Major
        Found in eFormSDK.Integration.Base.CoreTests/DbTestFixture.cs - About 3 hrs to fix

          Method ClearDb has 94 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  private async Task ClearDb()
        {
            List<string> modelNames = new List<string>
            {
                "CaseVersions",
          Severity: Major
          Found in eFormSDK.Integration.Case.CoreTests/DbTestFixture.cs - About 3 hrs to fix

            Method ClearDb has 94 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    private async Task ClearDb()
        {
            List<string> modelNames = new List<string>
            {
                "CaseVersions",
            Severity: Major
            Found in eFormSDK.InSight.Tests/DbTestFixture.cs - About 3 hrs to fix

              Method Core_Case_CaseIdLookUp_returnsId has 93 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      [Test]
        public async Task Core_Case_CaseIdLookUp_returnsId()
        {

            // Arrange
              Severity: Major
              Found in eFormSDK.Integration.Tests/CoreTestCase.cs - About 3 hrs to fix

                Method Answers_Create_DoesCreate has 93 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        [Test]
        public async Task Answers_Create_DoesCreate()
        {
            //Arrange
            Random rnd = new Random();
                Severity: Major
                Found in eFormSDK.InSight.Tests/AnswersUTest.cs - About 3 hrs to fix

                  Method SQL_Check_FieldValueReadList_ReturnsList has 92 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          [Test]
        public async Task SQL_Check_FieldValueReadList_ReturnsList()
        {
            // Arrance
                  Severity: Major
                  Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs - About 3 hrs to fix

                    Class CoreTestCase has 30 methods (exceeds 20 allowed). Consider refactoring.
                    Open

                        [TestFixture]
    public class CoreTestCase : DbTestFixture
    {
        private Core sut;
        private TestHelpers testHelpers;
                    Severity: Minor
                    Found in eFormSDK.Integration.Tests/CoreTestCase.cs - About 3 hrs to fix

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                                      switch (workflowState)
                {
                    case Constants.Constants.WorkflowStates.NotRetracted:
                        subQuery = subQuery.Where(x => x.WorkflowState != Constants.Constants.WorkflowStates.Retracted);
                        break;
                      Severity: Major
                      Found in eFormCore/Infrastructure/SqlController.cs and 1 other location - About 3 hrs to fix
                      eFormCore/Infrastructure/SqlController.cs on lines 3308..3325

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 248.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                                      switch (workflowState)
                {
                    case Constants.Constants.WorkflowStates.NotRetracted:
                        subQuery = subQuery.Where(x => x.WorkflowState != Constants.Constants.WorkflowStates.Retracted);
                        break;
                      Severity: Major
                      Found in eFormCore/Infrastructure/SqlController.cs and 1 other location - About 3 hrs to fix
                      eFormCore/Infrastructure/SqlController.cs on lines 3362..3379

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 248.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Method CreateField has 29 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              public async Task<Field> CreateField(short? barcodeEnabled, string barcodeType, CheckList checkList,
            string color, string custom, int? decimalCount, string defaultValue, string description, int? displayIndex,
            short? dummy, FieldType ft, short? geolocationEnabled, short? geolocationForced, short? geolocationHidden,
            short? isNum, string label, short? mandatory, int maxLength, string maxValue, string minValue, short? multi,
            short? optional, string queryType, short? readOnly, short? selected, short? split, short? stopOnSave,
                      Severity: Major
                      Found in eFormCore/Helpers/TestHelpers.cs - About 3 hrs to fix

                        Identical blocks of code found in 4 locations. Consider refactoring.
                        Open

                                public override async Task DoSetup()
        {
            #region Setup SettingsTableContent

            DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
                        Severity: Major
                        Found in eFormSDK.Integration.CheckLists.SqlControllerTests/SqlControllerTestReplyElementy.cs and 3 other locations - About 3 hrs to fix
                        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestField.cs on lines 46..66
                        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 50..70
                        eFormSDK.Integration.Case.SqlControllerTests/SqlControllerTestCaseReadAllShort.cs on lines 56..78

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 247.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 4 locations. Consider refactoring.
                        Open

                                public override async Task DoSetup()
        {
            #region Setup SettingsTableContent

            DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
                        Severity: Major
                        Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestField.cs and 3 other locations - About 3 hrs to fix
                        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 50..70
                        eFormSDK.Integration.Case.SqlControllerTests/SqlControllerTestCaseReadAllShort.cs on lines 56..78
                        eFormSDK.Integration.CheckLists.SqlControllerTests/SqlControllerTestReplyElementy.cs on lines 52..72

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 247.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 4 locations. Consider refactoring.
                        Open

                                public override async Task DoSetup()
        {
            #region Setup SettingsTableContent

            #region Setup SettingsTableContent
                        Severity: Major
                        Found in eFormSDK.Integration.Case.SqlControllerTests/SqlControllerTestCaseReadAllShort.cs and 3 other locations - About 3 hrs to fix
                        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestField.cs on lines 46..66
                        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs on lines 50..70
                        eFormSDK.Integration.CheckLists.SqlControllerTests/SqlControllerTestReplyElementy.cs on lines 52..72

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 247.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 4 locations. Consider refactoring.
                        Open

                                public override async Task DoSetup()
        {
            #region Setup SettingsTableContent

            DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
                        Severity: Major
                        Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestFieldValue.cs and 3 other locations - About 3 hrs to fix
                        eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestField.cs on lines 46..66
                        eFormSDK.Integration.Case.SqlControllerTests/SqlControllerTestCaseReadAllShort.cs on lines 56..78
                        eFormSDK.Integration.CheckLists.SqlControllerTests/SqlControllerTestReplyElementy.cs on lines 52..72

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 247.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Method Core_Folders_UpdateFolder_DoesUpdateFolderWithTranslations has 90 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                [Test]
        public async Task Core_Folders_UpdateFolder_DoesUpdateFolderWithTranslations()
        {
            // Arrange
                        Severity: Major
                        Found in eFormSDK.Integration.Base.CoreTests/CoreTestFolders.cs - About 3 hrs to fix

                          Method ClearDb has 90 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  private async Task ClearDb()
        {
            Console.WriteLine($"Starting ClearDb {DateTime.Now.ToString(CultureInfo.CurrentCulture)}");

            List<string> modelNames = new List<string>();
                          Severity: Major
                          Found in eFormSDK.Integration.Tests/DbTestFixture.cs - About 3 hrs to fix

                            Method AddDefaultLanguages has a Cognitive Complexity of 40 (exceeds 20 allowed). Consider refactoring.
                            Open

                                    public static async Task AddDefaultLanguages(MicrotingDbContext dbContext)
        {

            if (dbContext.Languages.FirstOrDefault(x => x.Name == "Danish") != null)
            {
                            Severity: Minor
                            Found in eFormCore/Infrastructure/Data/Entities/Language.cs - About 3 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language