microting/eform-sdk-dotnet

View on GitHub

Showing 3,203 of 3,219 total issues

Method Down has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        protected override void Down(MigrationBuilder migrationBuilder)
        {
            migrationBuilder.DropColumn(
                name: "MicrotingUid",
                table: "survey_configurations");
Severity: Major
Found in eFormCore/Migrations/20200120093951_CleanupInSight.cs - About 2 hrs to fix

    Method CheckRead has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public async Task<ReplyElement> CheckRead(int id, Language language)
            {
                string methodName = "SqlController.CheckRead";
                try
                {
    Severity: Major
    Found in eFormCore/Infrastructure/SqlController.cs - About 2 hrs to fix

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

                  FieldValue fieldValue = new FieldValue
                  {
                      Accuracy = Guid.NewGuid().ToString(),
                      Altitude = Guid.NewGuid().ToString(),
                      Date = DateTime.UtcNow,
      Severity: Major
      Found in eFormSDK.CheckLists.Tests/FieldValuesUTest.cs and 2 other locations - About 2 hrs to fix
      eFormSDK.CheckLists.Tests/FieldValuesUTest.cs on lines 434..449
      eFormSDK.CheckLists.Tests/FieldValuesUTest.cs on lines 704..719

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 159.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

                  FieldValue fieldValue = new FieldValue
                  {
                      Accuracy = Guid.NewGuid().ToString(),
                      Altitude = Guid.NewGuid().ToString(),
                      Date = DateTime.UtcNow,
      Severity: Major
      Found in eFormSDK.CheckLists.Tests/FieldValuesUTest.cs and 2 other locations - About 2 hrs to fix
      eFormSDK.CheckLists.Tests/FieldValuesUTest.cs on lines 203..218
      eFormSDK.CheckLists.Tests/FieldValuesUTest.cs on lines 434..449

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 159.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

                  FieldValue fieldValue = new FieldValue
                  {
                      Accuracy = Guid.NewGuid().ToString(),
                      Altitude = Guid.NewGuid().ToString(),
                      Date = DateTime.UtcNow,
      Severity: Major
      Found in eFormSDK.CheckLists.Tests/FieldValuesUTest.cs and 2 other locations - About 2 hrs to fix
      eFormSDK.CheckLists.Tests/FieldValuesUTest.cs on lines 203..218
      eFormSDK.CheckLists.Tests/FieldValuesUTest.cs on lines 704..719

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 159.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              public async Task<bool> EntityGroupUpdate(int entityGroupId, string entityGroupMUId)
              {
                  string methodName = "SqlController.EntityGroupUpdate";
                  try
                  {
      Severity: Major
      Found in eFormCore/Infrastructure/SqlController.cs and 1 other location - About 2 hrs to fix
      eFormCore/Infrastructure/SqlController.cs on lines 4928..4949

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 159.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              public async Task<bool> EntityGroupUpdateName(string name, string entityGroupMUId)
              {
                  string methodName = "SqlController.EntityGroupUpdateName";
                  try
                  {
      Severity: Major
      Found in eFormCore/Infrastructure/SqlController.cs and 1 other location - About 2 hrs to fix
      eFormCore/Infrastructure/SqlController.cs on lines 4899..4919

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 159.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              public string Locate(string textStr, string startStr, string endStr)
              {
                  try
                  {
                      if (!textStr.Contains(startStr))
      Severity: Major
      Found in eFormCore/Tools.cs and 1 other location - About 2 hrs to fix
      eFormCore/Infrastructure/Data/Entities/Field.cs on lines 341..360

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 158.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              private static string Locate(string textStr, string startStr, string endStr)
              {
                  try
                  {
                      if (!textStr.Contains(startStr))
      Severity: Major
      Found in eFormCore/Infrastructure/Data/Entities/Field.cs and 1 other location - About 2 hrs to fix
      eFormCore/Tools.cs on lines 158..177

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 158.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method SQL_Case_CaseUpdateCompleted_DoesCaseGetUpdated has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              [Test]
              public async Task SQL_Case_CaseUpdateCompleted_DoesCaseGetUpdated()
              {
                  MicrotingDbContext ldbContext = dbContextHelper.GetDbContext();
                  Random rnd = new Random();
      Severity: Major
      Found in eFormSDK.Integration.Case.SqlControllerTests/SqlControllerTestCase.cs - About 2 hrs to fix

        Method question_Create_DoesCreate_AllFalse has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                [Test]
                public async Task question_Create_DoesCreate_AllFalse()
                {
                    // Arrange
                    string name = Guid.NewGuid().ToString();
        Severity: Major
        Found in eFormSDK.Integration.Tests/SqlControllerTestQuestion.cs - About 2 hrs to fix

          Method question_Create_DoesCreate_QuestionSetFalse_PrioritisedBackButtonEnabledTrue has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                          [Test]
                  public async Task question_Create_DoesCreate_QuestionSetFalse_PrioritisedBackButtonEnabledTrue()
                  {
                      // Arrange
                      string name = Guid.NewGuid().ToString();
          Severity: Major
          Found in eFormSDK.Integration.Tests/SqlControllerTestQuestion.cs - About 2 hrs to fix

            Method question_Create_DoesCreate_QuestionSetFalse_PrioritisedValidDisplayBackButtonEnabledTrue has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    [Test]
                    public async Task question_Create_DoesCreate_QuestionSetFalse_PrioritisedValidDisplayBackButtonEnabledTrue()
                    {
                        // Arrange
                        string name = Guid.NewGuid().ToString();
            Severity: Major
            Found in eFormSDK.Integration.Tests/SqlControllerTestQuestion.cs - About 2 hrs to fix

              Method question_Create_DoesCreate_QuestionSetFalse_ImageTrue has 53 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      [Test]
                      public async Task question_Create_DoesCreate_QuestionSetFalse_ImageTrue()
                      {
                          // Arrange
                          string name = Guid.NewGuid().ToString();
              Severity: Major
              Found in eFormSDK.Integration.Tests/SqlControllerTestQuestion.cs - About 2 hrs to fix

                Method question_Create_DoesCreate_QuestionSetFalse_PrioritisedValidDisplayTrue has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                                [Test]
                        public async Task question_Create_DoesCreate_QuestionSetFalse_PrioritisedValidDisplayTrue()
                        {
                            // Arrange
                            string name = Guid.NewGuid().ToString();
                Severity: Major
                Found in eFormSDK.Integration.Tests/SqlControllerTestQuestion.cs - About 2 hrs to fix

                  Method question_Create_DoesCreate_QuestionSetFalse_PrioritisedImageTrue has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                                  [Test]
                          public async Task question_Create_DoesCreate_QuestionSetFalse_PrioritisedImageTrue()
                          {
                              // Arrange
                              string name = Guid.NewGuid().ToString();
                  Severity: Major
                  Found in eFormSDK.Integration.Tests/SqlControllerTestQuestion.cs - About 2 hrs to fix

                    Method question_Create_DoesCreate_QuestionSetFalse_BackButtonEnabledTrue has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            [Test]
                            public async Task question_Create_DoesCreate_QuestionSetFalse_BackButtonEnabledTrue()
                            {
                                // Arrange
                                string name = Guid.NewGuid().ToString();
                    Severity: Major
                    Found in eFormSDK.Integration.Tests/SqlControllerTestQuestion.cs - About 2 hrs to fix

                      Method question_Create_DoesCreate_QuestionSetFalse_ValidDisplayBackButtonEnabledImageTrue has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              [Test]
                              public async Task question_Create_DoesCreate_QuestionSetFalse_ValidDisplayBackButtonEnabledImageTrue()
                              {
                                  // Arrange
                                  string name = Guid.NewGuid().ToString();
                      Severity: Major
                      Found in eFormSDK.Integration.Tests/SqlControllerTestQuestion.cs - About 2 hrs to fix

                        Method question_Create_DoesCreate_QuestionSetFalse_ValidDisplayTrue has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                [Test]
                                public async Task question_Create_DoesCreate_QuestionSetFalse_ValidDisplayTrue()
                                {
                                    // Arrange
                                    string name = Guid.NewGuid().ToString();
                        Severity: Major
                        Found in eFormSDK.Integration.Tests/SqlControllerTestQuestion.cs - About 2 hrs to fix

                          Method question_Create_DoesCreate_QuestionSetFalse_ValidDisplayImageTrue has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                                  [Test]
                                  public async Task question_Create_DoesCreate_QuestionSetFalse_ValidDisplayImageTrue()
                                  {
                                      // Arrange
                                      string name = Guid.NewGuid().ToString();
                          Severity: Major
                          Found in eFormSDK.Integration.Tests/SqlControllerTestQuestion.cs - About 2 hrs to fix
                            Severity
                            Category
                            Status
                            Source
                            Language