microting/eform-sdk-dotnet

View on GitHub

Showing 3,203 of 3,219 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            switch (lastType)
            {
                case "picture":
                    jasperFieldXml.Append(Environment.NewLine);
                    jasperFieldXml.Append("</pictures>");
Severity: Major
Found in eFormCore/Core.cs and 1 other location - About 1 hr to fix
eFormCore/Core.cs on lines 5748..5762

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        public Task<string> Delete(string eFormId, int siteId)
        {
            _log.LogEverything("Communicator.Delete", "called");
            _log.LogVariable("Communicator.Delete", nameof(eFormId), eFormId);
            _log.LogVariable("Communicator.Delete", nameof(siteId), siteId);
Severity: Major
Found in eFormCore/Communication/Communicator.cs and 1 other location - About 1 hr to fix
eFormCore/Communication/Communicator.cs on lines 156..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        public Task<string> CheckStatus(string eFormId, int siteId)
        {
            _log.LogEverything("Communicator.CheckStatus", "called");
            _log.LogVariable("Communicator.CheckStatus", nameof(eFormId), eFormId);
            _log.LogVariable("Communicator.CheckStatus", nameof(siteId), siteId);
Severity: Major
Found in eFormCore/Communication/Communicator.cs and 1 other location - About 1 hr to fix
eFormCore/Communication/Communicator.cs on lines 249..256

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method Core_Template_TemplateUploAddAsyncata_ReturnsmainElement has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        [Test]
        public async Task Core_Template_TemplateUploAddAsyncata_ReturnsmainElement()
        {
            // Arrange
            CoreElement CElement = new CoreElement();
Severity: Minor
Found in eFormSDK.Integration.CheckLists.CoreTests/CoreTesteForm.cs - About 1 hr to fix

    Method CaseUpdateCompleted has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public async Task CaseUpdateCompleted(int microtingUId, int microtingCheckId, DateTime doneAt,
                int workerMicrotingUId, int unitMicrotingUid)
            {
                string methodName = "SqlController.CaseUpdateCompleted";
                try
    Severity: Minor
    Found in eFormCore/Infrastructure/SqlController.cs - About 1 hr to fix

      Method ClassToXml has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public string ClassToXml()
              {
                  try
                  {
                      string xmlStr = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" + Environment.NewLine +
      Severity: Minor
      Found in eFormCore/Infrastructure/Models/reply/Response.cs - About 1 hr to fix

        Method CreateSpecialOption has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                private async Task CreateSpecialOption(MicrotingDbContext dbContext, int weight, int weightedValue, string text,
                    int languageId, int optionIndex)
                {
                    var result = (from ot in dbContext.OptionTranslations
                        join o in dbContext.Options
        Severity: Minor
        Found in eFormCore/Infrastructure/Data/Entities/Question.cs - About 1 hr to fix

          Method SiteCreate has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  public async Task<Tuple<SiteDto, UnitDto>> SiteCreate(string name, string languageCode)
                  {
                      _log.LogEverything("Communicator.SiteCreate", "called");
                      _log.LogVariable("Communicator.SiteCreate", nameof(name), name);
          
          
          Severity: Minor
          Found in eFormCore/Communication/Communicator.cs - About 1 hr to fix

            Method Delete has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    public async Task<string> Delete(string elementId, string siteId)
                    {
                        try
                        {if (_addressNewApi != "none")
                            {
            Severity: Minor
            Found in eFormCore/Communication/Http.cs - About 1 hr to fix

              Method Workers_Create_DoesCreate has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      [Test]
                      public async Task Workers_Create_DoesCreate()
                      {
                          //Arrange
                          Random rnd = new Random();
              Severity: Minor
              Found in eFormSDK.Base.Tests/WorkersUTest.cs - About 1 hr to fix

                Method Tags_Delete_DoesSetWorkflowStateToRemoved has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        [Test]
                        public async Task Tags_Delete_DoesSetWorkflowStateToRemoved()
                        {
                            Random rnd = new Random();
                
                
                Severity: Minor
                Found in eFormSDK.Base.Tests/TagsUTest.cs - About 1 hr to fix

                  Method TranscribeUploadedData has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          public async Task<bool> TranscribeUploadedData(int uploadedDataId)
                          {
                              string methodName = "Core.TranscribeUploadedData";
                              try
                              {
                  Severity: Minor
                  Found in eFormCore/Core.cs - About 1 hr to fix

                    Similar blocks of code found in 7 locations. Consider refactoring.
                    Open

                                options option = new options
                                {
                                    WeightValue = rnd.Next(1, 255),
                                    QuestionId = question.Id,
                                    Weight = rnd.Next(1, 255),
                    Severity: Major
                    Found in eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs and 6 other locations - About 1 hr to fix
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 276..284
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 336..344
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 468..476
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 89..97
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 191..199
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 278..286

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 106.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 7 locations. Consider refactoring.
                    Open

                                options option = new options
                                {
                                    WeightValue = rnd.Next(1, 255),
                                    QuestionId = question.Id,
                                    Weight = rnd.Next(1, 255),
                    Severity: Major
                    Found in eFormSDK.Integration.Tests/SqlControllerTestOptions.cs and 6 other locations - About 1 hr to fix
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 153..161
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 276..284
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 336..344
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 468..476
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 89..97
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 278..286

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 106.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 7 locations. Consider refactoring.
                    Open

                                options option = new options
                                {
                                    WeightValue = rnd.Next(1, 255),
                                    QuestionId = question.Id,
                                    Weight = rnd.Next(1, 255),
                    Severity: Major
                    Found in eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs and 6 other locations - About 1 hr to fix
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 153..161
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 276..284
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 336..344
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 89..97
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 191..199
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 278..286

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 106.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 7 locations. Consider refactoring.
                    Open

                                options option = new options
                                {
                                    WeightValue = rnd.Next(1, 255),
                                    QuestionId = question.Id,
                                    Weight = rnd.Next(1, 255),
                    Severity: Major
                    Found in eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs and 6 other locations - About 1 hr to fix
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 153..161
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 336..344
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 468..476
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 89..97
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 191..199
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 278..286

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 106.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 7 locations. Consider refactoring.
                    Open

                                options option = new options
                                {
                                    WeightValue = rnd.Next(1, 255),
                                    QuestionId = question.Id,
                                    Weight = rnd.Next(1, 255),
                    Severity: Major
                    Found in eFormSDK.Integration.Tests/SqlControllerTestOptions.cs and 6 other locations - About 1 hr to fix
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 153..161
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 276..284
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 336..344
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 468..476
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 191..199
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 278..286

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 106.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 7 locations. Consider refactoring.
                    Open

                                options option2 = new options
                                {
                                    WeightValue = rnd.Next(1, 255),
                                    QuestionId = question.Id,
                                    Weight = rnd.Next(1, 255),
                    Severity: Major
                    Found in eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs and 6 other locations - About 1 hr to fix
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 153..161
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 276..284
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 468..476
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 89..97
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 191..199
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 278..286

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 106.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 7 locations. Consider refactoring.
                    Open

                                options option = new options
                                {
                                    WeightValue = rnd.Next(1, 255),
                                    QuestionId = question.Id,
                                    Weight = rnd.Next(1, 255),
                    Severity: Major
                    Found in eFormSDK.Integration.Tests/SqlControllerTestOptions.cs and 6 other locations - About 1 hr to fix
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 153..161
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 276..284
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 336..344
                    eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 468..476
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 89..97
                    eFormSDK.Integration.Tests/SqlControllerTestOptions.cs on lines 191..199

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 106.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                                    if (question.QuestionType == Constants.QuestionTypes.Buttons ||
                                                        question.QuestionType == Constants.QuestionTypes.List ||
                                                        question.QuestionType == Constants.QuestionTypes.Multi)
                                                    {
                                                        OptionTranslation optionTranslation =
                    Severity: Major
                    Found in eFormCore/Core.cs and 1 other location - About 1 hr to fix
                    eFormCore/Core.cs on lines 4227..4235

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 106.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language