init accesses the super-global variable $_SERVER. Open
public function init()
{
parent::init();
$error = $this->getParam('error_handler');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Function errorAction
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
public function errorAction()
{
$error = $this->getParam('error_handler');
if (!isset($error) || empty($error)) {
$this->getResponse()->setHttpResponseCode(404);
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method errorAction
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function errorAction()
{
$error = $this->getParam('error_handler');
if (!isset($error) || empty($error)) {
$this->getResponse()->setHttpResponseCode(404);
- Create a ticketCreate a ticket
The method errorAction() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10. Open
public function errorAction()
{
$error = $this->getParam('error_handler');
if (!isset($error) || empty($error)) {
$this->getResponse()->setHttpResponseCode(404);
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '40', column '24'). Open
$session = new Zend_Session_Namespace('Auth_User');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
The method errorAction uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->getLogger()->warn('URL: '.$this->Component->NotifyError->curPageURL()."\n".$fullMessage);
}
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method errorAction uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->haveToBeLogged();
return;
}
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method errorAction uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->getResponse()->setHttpResponseCode(500);
}
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class ErrorController extends AppController
- Create a ticketCreate a ticket
- Exclude checks
The property $_forms is not named in camelCase. Open
class ErrorController extends AppController
{
public $_models = array();
public $_daos = array();
public $_components = array('NotifyError', 'Utility');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $_error is not named in camelCase. Open
class ErrorController extends AppController
{
public $_models = array();
public $_daos = array();
public $_components = array('NotifyError', 'Utility');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $_models is not named in camelCase. Open
class ErrorController extends AppController
{
public $_models = array();
public $_daos = array();
public $_components = array('NotifyError', 'Utility');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $_daos is not named in camelCase. Open
class ErrorController extends AppController
{
public $_models = array();
public $_daos = array();
public $_components = array('NotifyError', 'Utility');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $_components is not named in camelCase. Open
class ErrorController extends AppController
{
public $_models = array();
public $_daos = array();
public $_components = array('NotifyError', 'Utility');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $_environment is not named in camelCase. Open
class ErrorController extends AppController
{
public $_models = array();
public $_daos = array();
public $_components = array('NotifyError', 'Utility');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
Property name "$_daos" should not be prefixed with an underscore to indicate visibility Open
public $_daos = array();
- Create a ticketCreate a ticket
- Exclude checks
Property name "$_error" should not be prefixed with an underscore to indicate visibility Open
private $_error;
- Create a ticketCreate a ticket
- Exclude checks
Property name "$_forms" should not be prefixed with an underscore to indicate visibility Open
public $_forms = array();
- Create a ticketCreate a ticket
- Exclude checks
Method name "_applicationError" should not be prefixed with an underscore to indicate visibility Open
private function _applicationError()
- Create a ticketCreate a ticket
- Exclude checks
Property name "$_models" should not be prefixed with an underscore to indicate visibility Open
public $_models = array();
- Create a ticketCreate a ticket
- Exclude checks
Property name "$_components" should not be prefixed with an underscore to indicate visibility Open
public $_components = array('NotifyError', 'Utility');
- Create a ticketCreate a ticket
- Exclude checks
Property name "$_environment" should not be prefixed with an underscore to indicate visibility Open
private $_environment;
- Create a ticketCreate a ticket
- Exclude checks
Line exceeds 120 characters; contains 146 characters Open
$this->view->message = "Midas Server is not installed. Please go the <a href = '".$this->view->webroot."/install'> install page</a>.";
- Create a ticketCreate a ticket
- Exclude checks
The method _applicationError is not named in camelCase. Open
private function _applicationError()
{
$fullMessage = $this->Component->NotifyError->getFullErrorMessage();
$shortMessage = $this->Component->NotifyError->getShortErrorMessage();
$this->fullMessage = $fullMessage;
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}