midasplatform/Midas

View on GitHub
core/controllers/components/MIDAS2MigrationComponent.php

Summary

Maintainability
F
1 wk
Test Coverage

Function _createFolderForItem has a Cognitive Complexity of 70 (exceeds 5 allowed). Consider refactoring.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

Severity: Minor
Found in core/controllers/components/MIDAS2MigrationComponent.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _createFolderForItem has 209 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

Severity: Major
Found in core/controllers/components/MIDAS2MigrationComponent.php - About 1 day to fix

File MIDAS2MigrationComponent.php has 441 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*=========================================================================
 Midas Server
 Copyright Kitware SAS, 26 rue Louis Guérin, 69100 Villeurbanne, France.
 All rights reserved.
Severity: Minor
Found in core/controllers/components/MIDAS2MigrationComponent.php - About 6 hrs to fix

The class MIDAS2MigrationComponent has an overall complexity of 65 which is very high. The configured complexity threshold is 50.
Open

class MIDAS2MigrationComponent extends AppComponent
{
    // These variables should be set by the UI

    /** @var string */

Function migrate has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode
Severity: Minor
Found in core/controllers/components/MIDAS2MigrationComponent.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method migrate has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode
Severity: Major
Found in core/controllers/components/MIDAS2MigrationComponent.php - About 3 hrs to fix

Function _createFolderForCollection has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

Severity: Minor
Found in core/controllers/components/MIDAS2MigrationComponent.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _createFolderForCommunity has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

Severity: Minor
Found in core/controllers/components/MIDAS2MigrationComponent.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _createFolderForCommunity has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

Severity: Major
Found in core/controllers/components/MIDAS2MigrationComponent.php - About 2 hrs to fix

Method _createFolderForCollection has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

Severity: Major
Found in core/controllers/components/MIDAS2MigrationComponent.php - About 2 hrs to fix

The method migrate() has an NPath complexity of 888. The configured NPath complexity threshold is 200.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method migrate() has 110 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

The method _createFolderForItem() has an NPath complexity of 33797. The configured NPath complexity threshold is 200.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method _createFolderForItem() has 278 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

The method _createFolderForItem() has a Cyclomatic Complexity of 33. The configured cyclomatic complexity threshold is 10.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method migrate() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Missing class import via use statement (line '321', column '41').
Open

                    $bitstreamDao = new BitstreamDao();

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '228', column '44').
Open

                    $itemRevisionDao = new ItemRevisionDao();

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '536', column '23').
Open

            throw new Zend_Exception("Please set your environment config variable to be 'development'.");

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '551', column '23').
Open

            throw new Zend_Exception("Password prefix cannot be set because MIDAS2 doesn't use salt.");

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '341', column '48').
Open

                        $UploadComponent = new UploadComponent();

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '546', column '23').
Open

            throw new Zend_Exception('Cannot connect to the MIDAS2 database.');

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '176', column '36').
Open

                    $itemdao = new ItemDao();

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'MidasLoader' in method '_createFolderForCommunity'.
Open

        $Folderpolicyuser = MidasLoader::loadModel('Folderpolicyuser');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method '_createFolderForCommunity'.
Open

        $User = MidasLoader::loadModel('User');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method '_createFolderForCollection'.
Open

        $Folderpolicygroup = MidasLoader::loadModel('Folderpolicygroup');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method '_createFolderForItem'.
Open

                    $MetadataModel = MidasLoader::loadModel('Metadata');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method '_createFolderForCommunity'.
Open

        $Folderpolicygroup = MidasLoader::loadModel('Folderpolicygroup');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method 'migrate'.
Open

        $User = MidasLoader::loadModel('User');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method '_createFolderForItem'.
Open

        $ItemRevision = MidasLoader::loadModel('ItemRevision');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method '_createFolderForItem'.
Open

        $Folderpolicyuser = MidasLoader::loadModel('Folderpolicyuser');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method _createFolderForCommunity uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                echo 'Cannot create Folder for community: '.$name.'<br>';
            }

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'MidasLoader' in method 'migrate'.
Open

        $Community = MidasLoader::loadModel('Community');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method '_createFolderForItem'.
Open

        $User = MidasLoader::loadModel('User');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method _createFolderForCollection uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                echo 'Cannot create Folder for collection: '.$name.'<br>';
            }

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'MidasLoader' in method '_createFolderForItem'.
Open

        $Folder = MidasLoader::loadModel('Folder');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method '_createFolderForItem'.
Open

        $Itempolicygroup = MidasLoader::loadModel('Itempolicygroup');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method '_createFolderForCollection'.
Open

        $Folderpolicyuser = MidasLoader::loadModel('Folderpolicyuser');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method _createFolderForCommunity uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                    } else {
                        $policyValue = MIDAS_POLICY_READ;
                    }

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'MidasLoader' in method '_createFolderForItem'.
Open

        $Itempolicyuser = MidasLoader::loadModel('Itempolicyuser');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method _createFolderForItem uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                        } else {
                            $policyValue = MIDAS_POLICY_READ;
                        }

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'MidasLoader' in method '_createFolderForItem'.
Open

        $Item = MidasLoader::loadModel('Item');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method '_createFolderForItem'.
Open

        $Folderpolicygroup = MidasLoader::loadModel('Folderpolicygroup');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method 'migrate'.
Open

        $Group = MidasLoader::loadModel('Group');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method '_createFolderForItem'.
Open

        $Group = MidasLoader::loadModel('Group');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method '_createFolderForCollection'.
Open

        $User = MidasLoader::loadModel('User');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method '_createFolderForCommunity'.
Open

        $Folder = MidasLoader::loadModel('Folder');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method '_createFolderForItem'.
Open

        $Assetstore = MidasLoader::loadModel('Assetstore');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Zend_Debug' in method '_createFolderForItem'.
Open

                Zend_Debug::dump($e);

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method migrate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                    } else {
                        $memberGroupDao = $communityDao->getMemberGroup();
                    }

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method migrate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                echo 'Cannot create community: '.$name.'<br>';
            }

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method _createFolderForItem uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                echo 'Cannot create Folder for item: '.$title.'<br>';
            }

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'MidasLoader' in method '_createFolderForCollection'.
Open

        $Folder = MidasLoader::loadModel('Folder');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method _createFolderForItem uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                    } else {
                        $policyValue = MIDAS_POLICY_READ;
                    }

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method _createFolderForCollection uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                    } else {
                        $policyValue = MIDAS_POLICY_READ;
                    }

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        while ($colquery_array = pg_fetch_array($colquery)) {
            $collection_id = $colquery_array['collection_id'];
            $name = $colquery_array['name'];
            $short_description = $colquery_array['short_description'];
            $folderDao = false;
Severity: Major
Found in core/controllers/components/MIDAS2MigrationComponent.php and 1 other location - About 1 day to fix
core/controllers/components/MIDAS2MigrationComponent.php on lines 464..521

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 400.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        while ($comquery_array = pg_fetch_array($comquery)) {
            $community_id = $comquery_array['community_id'];
            $name = $comquery_array['name'];
            $short_description = $comquery_array['short_description'];
            $folderDao = false;
Severity: Major
Found in core/controllers/components/MIDAS2MigrationComponent.php and 1 other location - About 1 day to fix
core/controllers/components/MIDAS2MigrationComponent.php on lines 378..434

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 400.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class MIDAS2MigrationComponent extends AppComponent

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 28 and the first side effect is on line 21.
Open

<?php

Method name "_createFolderForCollection" should not be prefixed with an underscore to indicate visibility
Open

    private function _createFolderForCollection($communityId, $parentFolderid)

Method name "_createFolderForCommunity" should not be prefixed with an underscore to indicate visibility
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)

Method name "_createFolderForItem" should not be prefixed with an underscore to indicate visibility
Open

    private function _createFolderForItem($collectionId, $parentFolderid)

Line exceeds 120 characters; contains 175 characters
Open

                                   WHERE epersongroup_id IS NULL AND resource_type_id='.MIDAS2_RESOURCE_ITEM.' AND resource_id='.$item_id.' GROUP BY eperson.eperson_id, email'

Line exceeds 120 characters; contains 185 characters
Open

                                 WHERE epersongroup_id IS NULL AND resource_type_id='.MIDAS2_RESOURCE_COLLECTION.' AND resource_id='.$collection_id.' GROUP BY eperson.eperson_id, email'

Line exceeds 120 characters; contains 369 characters
Open

            'SELECT i.item_id, mtitle.text_value AS title, mabstract.text_value AS abstract '.'FROM item AS i '.'LEFT JOIN metadatavalue AS mtitle ON (i.item_id = mtitle.item_id AND mtitle.metadata_field_id = 64) '.'LEFT JOIN metadatavalue AS mabstract ON (i.item_id = mabstract.item_id AND mabstract.metadata_field_id = 27) '.'WHERE i.owning_collection='.$collectionId

Line exceeds 120 characters; contains 135 characters
Open

            'SELECT community_id, name, short_description, introductory_text FROM community WHERE owning_community='.$communityidMIDAS2

Line exceeds 120 characters; contains 172 characters
Open

            "host='".$this->midas2Host."' port='".$this->midas2Port."' dbname='".$this->midas2Database."' user='".$this->midas2User."' password='".$this->midas2Password."'"

Line exceeds 120 characters; contains 167 characters
Open

                    'SELECT policy_id FROM resourcepolicy WHERE resource_type_id='.MIDAS2_RESOURCE_COMMUNITY.' AND resource_id='.$community_id.' AND epersongroup_id=0'

Line exceeds 120 characters; contains 195 characters
Open

                    'SELECT   b.bitstream_id, b.name, b.description, b.internal_id FROM bitstream AS b, item2bitstream AS i2b '.'WHERE i2b.bitstream_id = b.bitstream_id AND i2b.item_id='.$item_id

Line exceeds 120 characters; contains 161 characters
Open

                        'SELECT policy_id FROM resourcepolicy WHERE resource_type_id='.MIDAS2_RESOURCE_ITEM.' AND resource_id='.$item_id.' AND epersongroup_id=0'

Line exceeds 120 characters; contains 173 characters
Open

                                 WHERE epersongroup_id IS NULL AND resource_type_id='.MIDAS2_RESOURCE_ITEM.' AND resource_id='.$item_id.' GROUP BY eperson.eperson_id, email'

Line exceeds 120 characters; contains 183 characters
Open

                                 WHERE epersongroup_id IS NULL AND resource_type_id='.MIDAS2_RESOURCE_COMMUNITY.' AND resource_id='.$community_id.' GROUP BY eperson.eperson_id, email'

Line exceeds 120 characters; contains 131 characters
Open

            'SELECT collection_id, name, short_description, introductory_text FROM collection WHERE owning_community='.$communityId

Line exceeds 120 characters; contains 183 characters
Open

                                 WHERE epersongroup_id IS NULL AND resource_type_id='.MIDAS2_RESOURCE_COMMUNITY.' AND resource_id='.$community_id.' GROUP BY eperson.eperson_id, email'

The variable $Item is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $item_id is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Itempolicyuser is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $text_value is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $internal_id is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folderpolicyuser is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folder is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $comquery_array is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policyquery_array is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $User is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $query_array is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $community_id is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folder is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Group is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $colquery_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $colquery_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policyquery_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $itemstats_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Itempolicygroup is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $MetadataModel is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $text_value is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $collection_id is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $short_description is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ItemRevision is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $User is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $metadata_field_id is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folder is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $User is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $colquery_array is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policyquery_array is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $community_id is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Community is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policyquery_array is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $colquery_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folderpolicygroup is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policyquery_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policyquery_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $collection_id is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policyquery_array is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policyquery_array is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folder is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folderpolicyuser is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $User is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $query_array is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policyquery_array is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $item_id is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folder is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $item_id is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $metadata_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $UploadComponent is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folderpolicyuser is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $comquery_array is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folderpolicygroup is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $User is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $query_array is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folderpolicyuser is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ItemRevision is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folderpolicygroup is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $comquery_array is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folder is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $community_id is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Itempolicyuser is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Group is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $internal_id is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $query_array is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $colquery_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $MetadataModel is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $metadata_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $internal_id is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $internal_id is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $short_description is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $User is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folderpolicygroup is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Itempolicygroup is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folderpolicyuser is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policyquery_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Item is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $bitquery_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Assetstore is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folderpolicyuser is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $comquery_array is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Group is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $query_array is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $short_description is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $community_id is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $UploadComponent is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policyquery_array is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policyquery_array is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $query_array is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $community_id is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $User is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $item_id is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $itemstats_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policyquery_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $User is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $internal_id is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folderpolicygroup is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folder is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folderpolicygroup is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $community_id is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $User is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Item is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $metadata_field_id is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $query_array is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policyquery_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $item_id is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $item_id is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $colquery_array is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $colquery_array is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $short_description is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $User is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Assetstore is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folderpolicyuser is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $item_id is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $bitquery_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $itemstats_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $metadata_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folder is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $short_description is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $community_id is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $User is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Community is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folder is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $bitquery_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $colquery_array is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $short_description is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folderpolicyuser is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policyquery_array is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $itemstats_array is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folder is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $UploadComponent is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Folderpolicyuser is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $collection_id is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $query_array is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $query_array is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Community is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Group is not named in camelCase.
Open

    public function migrate($userid)
    {
        $this->userId = $userid;

        // Check that we are in development mode

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method _createFolderForCollection is not named in camelCase.
Open

    private function _createFolderForCollection($communityId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _createFolderForItem is not named in camelCase.
Open

    private function _createFolderForItem($collectionId, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _createFolderForCommunity is not named in camelCase.
Open

    private function _createFolderForCommunity($communityidMIDAS2, $parentFolderid)
    {
        /** @var FolderModel $Folder */
        $Folder = MidasLoader::loadModel('Folder');

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status