Function _formatResults
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
private function _formatResults($order, $items, $folders, $communities, $users)
{
foreach ($users as $key => $user) {
$users[$key]->name = $user->getLastname();
$users[$key]->date_update = $user->getCreation();
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method _formatResults
has 68 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function _formatResults($order, $items, $folders, $communities, $users)
{
foreach ($users as $key => $user) {
$users[$key]->name = $user->getLastname();
$users[$key]->date_update = $user->getCreation();
- Create a ticketCreate a ticket
Method _formatResults
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
private function _formatResults($order, $items, $folders, $communities, $users)
- Create a ticketCreate a ticket
The method _formatResults() has an NPath complexity of 476. The configured NPath complexity threshold is 200. Open
private function _formatResults($order, $items, $folders, $communities, $users)
{
foreach ($users as $key => $user) {
$users[$key]->name = $user->getLastname();
$users[$key]->date_update = $user->getCreation();
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method _formatResults() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10. Open
private function _formatResults($order, $items, $folders, $communities, $users)
{
foreach ($users as $key => $user) {
$users[$key]->name = $user->getLastname();
$users[$key]->date_update = $user->getCreation();
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '93', column '33'). Open
$sortdaoComponent = new SortdaoComponent();
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '94', column '30'). Open
$dateComponent = new DateComponent();
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '125', column '27'). Open
throw new Zend_Exception('Error in order parameter, not one of the expected values.');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class 'MidasLoader' in method 'searchAll'. Open
$folderModel = MidasLoader::loadModel('Folder');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'MidasLoader' in method 'searchAll'. Open
$communityModel = MidasLoader::loadModel('Community');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Zend_Loader' in method '_formatResults'. Open
Zend_Loader::loadClass('DateComponent', BASE_PATH.'/core/controllers/components');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'MidasLoader' in method 'searchAll'. Open
$itemModel = MidasLoader::loadModel('Item');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'MidasLoader' in method 'searchAll'. Open
$userModel = MidasLoader::loadModel('User');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Zend_Loader' in method '_formatResults'. Open
Zend_Loader::loadClass('SortdaoComponent', BASE_PATH.'/core/controllers/components');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class SearchComponent extends AppComponent
- Create a ticketCreate a ticket
- Exclude checks
Method name "_formatResults" should not be prefixed with an underscore to indicate visibility Open
private function _formatResults($order, $items, $folders, $communities, $users)
- Create a ticketCreate a ticket
- Exclude checks
The variable $ItemsDao is not named in camelCase. Open
public function searchAll($userDao, $search, $order)
{
/** @var ItemModel $itemModel */
$itemModel = MidasLoader::loadModel('Item');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $UsersDao is not named in camelCase. Open
public function searchAll($userDao, $search, $order)
{
/** @var ItemModel $itemModel */
$itemModel = MidasLoader::loadModel('Item');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ItemsDao is not named in camelCase. Open
public function searchAll($userDao, $search, $order)
{
/** @var ItemModel $itemModel */
$itemModel = MidasLoader::loadModel('Item');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ItemsDao is not named in camelCase. Open
public function searchAll($userDao, $search, $order)
{
/** @var ItemModel $itemModel */
$itemModel = MidasLoader::loadModel('Item');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $CommunitiesDao is not named in camelCase. Open
public function searchAll($userDao, $search, $order)
{
/** @var ItemModel $itemModel */
$itemModel = MidasLoader::loadModel('Item');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $FoldersDao is not named in camelCase. Open
public function searchAll($userDao, $search, $order)
{
/** @var ItemModel $itemModel */
$itemModel = MidasLoader::loadModel('Item');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $CommunitiesDao is not named in camelCase. Open
public function searchAll($userDao, $search, $order)
{
/** @var ItemModel $itemModel */
$itemModel = MidasLoader::loadModel('Item');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $UsersDao is not named in camelCase. Open
public function searchAll($userDao, $search, $order)
{
/** @var ItemModel $itemModel */
$itemModel = MidasLoader::loadModel('Item');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $UsersDao is not named in camelCase. Open
public function searchAll($userDao, $search, $order)
{
/** @var ItemModel $itemModel */
$itemModel = MidasLoader::loadModel('Item');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $FoldersDao is not named in camelCase. Open
public function searchAll($userDao, $search, $order)
{
/** @var ItemModel $itemModel */
$itemModel = MidasLoader::loadModel('Item');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $FoldersDao is not named in camelCase. Open
public function searchAll($userDao, $search, $order)
{
/** @var ItemModel $itemModel */
$itemModel = MidasLoader::loadModel('Item');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $CommunitiesDao is not named in camelCase. Open
public function searchAll($userDao, $search, $order)
{
/** @var ItemModel $itemModel */
$itemModel = MidasLoader::loadModel('Item');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The method _formatResults is not named in camelCase. Open
private function _formatResults($order, $items, $folders, $communities, $users)
{
foreach ($users as $key => $user) {
$users[$key]->name = $user->getLastname();
$users[$key]->date_update = $user->getCreation();
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}