Sign upLogin

midasplatform/Midas

View on GitHub
Star
core/controllers/forms/CommunityForm.php

Summary

Maintainability
B
6 hrs
Test Coverage

Missing class import via use statement (line '119', column '21').
Open

        $form = new Zend_Form();
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '123', column '21').
Open

        $name = new Zend_Form_Element_Text('name');
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '79', column '21').
Open

        $form = new Zend_Form();
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '46', column '21').
Open

        $name = new Zend_Form_Element_Text('name');
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '126', column '24').
Open

        $submit = new  Zend_Form_Element_Submit('submit');
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '108', column '24').
Open

        $submit = new  Zend_Form_Element_Submit('submit');
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '88', column '24').
Open

        $submit = new  Zend_Form_Element_Submit('submit');
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '65', column '24').
Open

        $canJoin = new Zend_Form_Element_Radio('canJoin');
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '27', column '21').
Open

        $form = new Zend_Form();
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '57', column '24').
Open

        $privacy = new Zend_Form_Element_Radio('privacy');
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '35', column '24').
Open

        $submit = new  Zend_Form_Element_Submit('submit');
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '49', column '28').
Open

        $description = new Zend_Form_Element_Textarea('description');
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '99', column '21').
Open

        $form = new Zend_Form();
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function createInfoForm($communityDao)
    {
        $form = new Zend_Form();

        $action = $this->webroot.'/community/manage?communityId='.$communityDao->getCommunityId();
Severity: Major
Found in core/controllers/forms/CommunityForm.php and 1 other location - About 3 hrs to fix
core/controllers/forms/CommunityForm.php on lines 97..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 146.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function createPrivacyForm($communityDao)
    {
        $form = new Zend_Form();

        $action = $this->webroot.'/community/manage?communityId='.$communityDao->getCommunityId();
Severity: Major
Found in core/controllers/forms/CommunityForm.php and 1 other location - About 3 hrs to fix
core/controllers/forms/CommunityForm.php on lines 77..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 146.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class CommunityForm extends AppForm
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpcodesniffer

Method name "_getPrivacyFormElements" should not be prefixed with an underscore to indicate visibility
Open

    protected function _getPrivacyFormElements()
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpcodesniffer

Method name "_getInfoFormElements" should not be prefixed with an underscore to indicate visibility
Open

    protected function _getInfoFormElements()
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpcodesniffer

The method _getInfoFormElements is not named in camelCase.
Open

    protected function _getInfoFormElements()
    {
        $name = new Zend_Form_Element_Text('name');
        $name->setRequired(true)->addValidator('NotEmpty', true);
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getPrivacyFormElements is not named in camelCase.
Open

    protected function _getPrivacyFormElements()
    {
        $privacy = new Zend_Form_Element_Radio('privacy');
        $privacy->addMultiOptions(
            array(
Severity: Minor
Found in core/controllers/forms/CommunityForm.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status