Sign upLogin

midasplatform/Midas

View on GitHub
Star
core/database/upgrade/3.2.1.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '27', column '21').
Open

        $user = new Zend_Session_Namespace('Auth_User');
Severity: Minor
Found in core/database/upgrade/3.2.1.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'MidasLoader' in method 'postUpgrade'.
Open

        $settingModel = MidasLoader::loadModel('Setting');
Severity: Minor
Found in core/database/upgrade/3.2.1.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Upgrade_3_2_1 extends MIDASUpgrade
Severity: Minor
Found in core/database/upgrade/3.2.1.php by phpcodesniffer

The class Upgrade_3_2_1 is not named in CamelCase.
Open

class Upgrade_3_2_1 extends MIDASUpgrade
{
    /** Post database upgrade. */
    public function postUpgrade()
    {
Severity: Minor
Found in core/database/upgrade/3.2.1.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Avoid variables with short names like $id. Configured minimum length is 3.
Open

        $id = $user && $user->Dao ? $user->Dao->getKey() : '1';
Severity: Minor
Found in core/database/upgrade/3.2.1.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Class name "Upgrade_3_2_1" is not in camel caps format
Open

class Upgrade_3_2_1 extends MIDASUpgrade
Severity: Minor
Found in core/database/upgrade/3.2.1.php by phpcodesniffer

There are no issues that match your filters.

Category
Status