midasplatform/Midas

View on GitHub
core/models/pdo/FolderModel.php

Summary

Maintainability
F
2 wks
Test Coverage

File FolderModel.php has 1129 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*=========================================================================
 Midas Server
 Copyright Kitware SAS, 26 rue Louis Guérin, 69100 Villeurbanne, France.
 All rights reserved.
Severity: Major
Found in core/models/pdo/FolderModel.php - About 2 days to fix

Method getSizeFiltered has 119 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getSizeFiltered($folders, $userDao = null, $policy = 0)
    {
        $isAdmin = false;
        if (!is_array($folders)) {
            $folders = array($folders);
Severity: Major
Found in core/models/pdo/FolderModel.php - About 4 hrs to fix

Method getFoldersFromSearch has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getFoldersFromSearch($search, $userDao, $limit = 14, $group = true, $order = 'view')
    {
        if (Zend_Registry::get('configDatabase')->database->adapter == 'PDO_PGSQL'
        ) {
            $group = false; // Postgresql don't like the sql request with group by
Severity: Major
Found in core/models/pdo/FolderModel.php - About 4 hrs to fix

Function getFoldersFromSearch has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    public function getFoldersFromSearch($search, $userDao, $limit = 14, $group = true, $order = 'view')
    {
        if (Zend_Registry::get('configDatabase')->database->adapter == 'PDO_PGSQL'
        ) {
            $group = false; // Postgresql don't like the sql request with group by
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

FolderModel has 33 functions (exceeds 20 allowed). Consider refactoring.
Open

class FolderModel extends FolderModelBase
{
    /**
     * Get all.
     *
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 4 hrs to fix

The class FolderModel has 11 public methods. Consider refactoring FolderModel to keep number of public methods under 10.
Open

class FolderModel extends FolderModelBase
{
    /**
     * Get all.
     *
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The class FolderModel has an overall complexity of 169 which is very high. The configured complexity threshold is 50.
Open

class FolderModel extends FolderModelBase
{
    /**
     * Get all.
     *
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

Function save has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function save($folder)
    {
        if (!$folder instanceof FolderDao) {
            throw new Zend_Exception('Should be a folder.');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method move has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Major
Found in core/models/pdo/FolderModel.php - About 2 hrs to fix

Method getAllChildren has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getAllChildren($folder, $userDao, $admin = false, $policy = 0)
    {
        $isAdmin = false;
        if ($userDao == null) {
            $userId = -1;
Severity: Major
Found in core/models/pdo/FolderModel.php - About 2 hrs to fix

Method save has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function save($folder)
    {
        if (!$folder instanceof FolderDao) {
            throw new Zend_Exception('Should be a folder.');
        }
Severity: Major
Found in core/models/pdo/FolderModel.php - About 2 hrs to fix

Function zipStream has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function zipStream(&$zip, $path, $folder, &$userDao, &$overrideOutputFunction = null)
    {
        $folderIds = array($folder->getKey());
        $this->Item = MidasLoader::loadModel('Item');

Severity: Minor
Found in core/models/pdo/FolderModel.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getSizeFiltered has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function getSizeFiltered($folders, $userDao = null, $policy = 0)
    {
        $isAdmin = false;
        if (!is_array($folders)) {
            $folders = array($folders);
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method delete has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function delete($folder, $progressDao = null)
    {
        if (!$folder instanceof FolderDao) {
            throw new Zend_Exception('Should be a folder');
        }
Severity: Major
Found in core/models/pdo/FolderModel.php - About 2 hrs to fix

Method removeOrphans has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function removeOrphans($progressDao = null)
    {
        if ($progressDao) {
            $max = $this->countOrphans();
            $progressDao->setMaximum($max);
Severity: Major
Found in core/models/pdo/FolderModel.php - About 2 hrs to fix

Method policyCheck has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function policyCheck($folderDao, $userDao = null, $policy = 0)
    {
        if (!$folderDao instanceof FolderDao || !is_numeric($policy)) {
            throw new Zend_Exception('Error in params when checking Folder Policy.');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 1 hr to fix

Method zipStream has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function zipStream(&$zip, $path, $folder, &$userDao, &$overrideOutputFunction = null)
    {
        $folderIds = array($folder->getKey());
        $this->Item = MidasLoader::loadModel('Item');

Severity: Minor
Found in core/models/pdo/FolderModel.php - About 1 hr to fix

Method getMaxPolicy has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getMaxPolicy($folderId, $user)
    {
        $maxPolicy = -1;
        if ($user) {
            if ($user->isAdmin()) {
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 1 hr to fix

Method _buildChildItemsQuery has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function _buildChildItemsQuery(&$userDao, &$folderIds, $policy, $sortfield = 'name', $sortdir = 'asc')
    {
        $userId = $userDao instanceof UserDao ? $userDao->getKey() : -1;
        $isAdmin = $userDao instanceof UserDao ? $userDao->isAdmin() : false;

Severity: Minor
Found in core/models/pdo/FolderModel.php - About 1 hr to fix

Function delete has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function delete($folder, $progressDao = null)
    {
        if (!$folder instanceof FolderDao) {
            throw new Zend_Exception('Should be a folder');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _buildChildFoldersQuery has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function _buildChildFoldersQuery(&$userDao, &$folderIds, $policy, $sortfield = 'name', $sortdir = 'asc')
    {
        $userId = $userDao instanceof UserDao ? $userDao->getKey() : -1;
        $isAdmin = $userDao instanceof UserDao ? $userDao->isAdmin() : false;

Severity: Minor
Found in core/models/pdo/FolderModel.php - About 1 hr to fix

Method _recomputeSubtree has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _recomputeSubtree($folder, &$count, $max, $progressDao = null)
    {
        ++$count;
        if ($progressDao && $count % 10 == 0) { // only update progress every 10 folders
            $message = 'Rebuilding entire folder tree index ('.$count.'/'.$max.')';
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 1 hr to fix

Function getAllChildren has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function getAllChildren($folder, $userDao, $admin = false, $policy = 0)
    {
        $isAdmin = false;
        if ($userDao == null) {
            $userId = -1;
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function removeOrphans has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function removeOrphans($progressDao = null)
    {
        if ($progressDao) {
            $max = $this->countOrphans();
            $progressDao->setMaximum($max);
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getRecursiveChildCount has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getRecursiveChildCount($folder)
    {
        $sql = $this->database->select()->setIntegrityCheck(false)->from(
            array('f' => 'folder'),
            array('count' => 'count(*)')
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 1 hr to fix

Method getChildrenFoldersFiltered has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $folder,
        $userDao = null,
        $policy = 0,
        $sortfield = 'name',
        $sortdir = 'asc',
Severity: Major
Found in core/models/pdo/FolderModel.php - About 50 mins to fix

Method getItemsFiltered has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $folder,
        $userDao = null,
        $policy = 0,
        $sortfield = 'name',
        $sortdir = 'asc',
Severity: Major
Found in core/models/pdo/FolderModel.php - About 50 mins to fix

Function policyCheck has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function policyCheck($folderDao, $userDao = null, $policy = 0)
    {
        if (!$folderDao instanceof FolderDao || !is_numeric($policy)) {
            throw new Zend_Exception('Error in params when checking Folder Policy.');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function move has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getMaxPolicy has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function getMaxPolicy($folderId, $user)
    {
        $maxPolicy = -1;
        if ($user) {
            if ($user->isAdmin()) {
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _buildChildFoldersQuery has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private function _buildChildFoldersQuery(&$userDao, &$folderIds, $policy, $sortfield = 'name', $sortdir = 'asc')
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 35 mins to fix

Method getFoldersFromSearch has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function getFoldersFromSearch($search, $userDao, $limit = 14, $group = true, $order = 'view')
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 35 mins to fix

Method _buildChildItemsQuery has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private function _buildChildItemsQuery(&$userDao, &$folderIds, $policy, $sortfield = 'name', $sortdir = 'asc')
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 35 mins to fix

Method zipStream has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function zipStream(&$zip, $path, $folder, &$userDao, &$overrideOutputFunction = null)
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 35 mins to fix

Function getItemsFiltered has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getItemsFiltered(
        $folder,
        $userDao = null,
        $policy = 0,
        $sortfield = 'name',
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getChildrenFoldersFiltered has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getChildrenFoldersFiltered(
        $folder,
        $userDao = null,
        $policy = 0,
        $sortfield = 'name',
Severity: Minor
Found in core/models/pdo/FolderModel.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method delete() has an NPath complexity of 1152. The configured NPath complexity threshold is 200.
Open

    public function delete($folder, $progressDao = null)
    {
        if (!$folder instanceof FolderDao) {
            throw new Zend_Exception('Should be a folder');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method move() has an NPath complexity of 384. The configured NPath complexity threshold is 200.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method getSizeFiltered() has 129 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    public function getSizeFiltered($folders, $userDao = null, $policy = 0)
    {
        $isAdmin = false;
        if (!is_array($folders)) {
            $folders = array($folders);
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

The method save() has an NPath complexity of 3402. The configured NPath complexity threshold is 200.
Open

    public function save($folder)
    {
        if (!$folder instanceof FolderDao) {
            throw new Zend_Exception('Should be a folder.');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method getSizeFiltered() has an NPath complexity of 264. The configured NPath complexity threshold is 200.
Open

    public function getSizeFiltered($folders, $userDao = null, $policy = 0)
    {
        $isAdmin = false;
        if (!is_array($folders)) {
            $folders = array($folders);
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The class FolderModel has 1544 lines of code. Current threshold is 1000. Avoid really long classes.
Open

class FolderModel extends FolderModelBase
{
    /**
     * Get all.
     *
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

The method getFoldersFromSearch() has an NPath complexity of 10864. The configured NPath complexity threshold is 200.
Open

    public function getFoldersFromSearch($search, $userDao, $limit = 14, $group = true, $order = 'view')
    {
        if (Zend_Registry::get('configDatabase')->database->adapter == 'PDO_PGSQL'
        ) {
            $group = false; // Postgresql don't like the sql request with group by
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method getFoldersFromSearch() has 127 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    public function getFoldersFromSearch($search, $userDao, $limit = 14, $group = true, $order = 'view')
    {
        if (Zend_Registry::get('configDatabase')->database->adapter == 'PDO_PGSQL'
        ) {
            $group = false; // Postgresql don't like the sql request with group by
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

The method delete() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
Open

    public function delete($folder, $progressDao = null)
    {
        if (!$folder instanceof FolderDao) {
            throw new Zend_Exception('Should be a folder');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method move() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method save() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10.
Open

    public function save($folder)
    {
        if (!$folder instanceof FolderDao) {
            throw new Zend_Exception('Should be a folder.');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method getSizeFiltered() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
Open

    public function getSizeFiltered($folders, $userDao = null, $policy = 0)
    {
        $isAdmin = false;
        if (!is_array($folders)) {
            $folders = array($folders);
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method getFoldersFromSearch() has a Cyclomatic Complexity of 20. The configured cyclomatic complexity threshold is 10.
Open

    public function getFoldersFromSearch($search, $userDao, $limit = 14, $group = true, $order = 'view')
    {
        if (Zend_Registry::get('configDatabase')->database->adapter == 'PDO_PGSQL'
        ) {
            $group = false; // Postgresql don't like the sql request with group by
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Missing class import via use statement (line '235', column '79').
Open

            'i2f.folder_id = '.$folder->getKey().' OR i2f.folder_id IN ('.new Zend_Db_Expr(
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '458', column '23').
Open

            throw new Zend_Exception('Should be a folder');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '624', column '23').
Open

            throw new Zend_Exception('Error in parameter folder when moving folder.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '627', column '23').
Open

            throw new Zend_Exception('Error in parameter parent when moving folder.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '654', column '39').
Open

            array('left_index' => new Zend_Db_Expr('left_index - '.$node_size)),
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '659', column '40').
Open

            array('right_index' => new Zend_Db_Expr('right_index - '.$node_size)),
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '491', column '58').
Open

                                      group_id IN ('.new Zend_Db_Expr(
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '278', column '27').
Open

                throw new Zend_Exception('Should be a folder');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '317', column '60').
Open

                                        group_id IN ('.new Zend_Db_Expr(
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '585', column '40').
Open

            array('right_index' => new Zend_Db_Expr('right_index - 2')),
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '445', column '23').
Open

            throw new Zend_Exception('Should be an user.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '682', column '38').
Open

                'right_index' => new Zend_Db_Expr('0 - right_index + '.$cond),
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '757', column '44').
Open

                array('right_index' => new Zend_Db_Expr('2 + right_index')),
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '618', column '27').
Open

                throw new Zend_Exception('Parent is a child of Folder');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '538', column '23').
Open

            throw new Zend_Exception('Unable to find the key');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '117', column '23').
Open

            throw new Zend_Exception('Should be an user.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '646', column '38').
Open

                'right_index' => new Zend_Db_Expr('0 - right_index'),
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '197', column '39').
Open

            ).' OR group_id IN ('.new Zend_Db_Expr(
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '667', column '39').
Open

            array('left_index' => new Zend_Db_Expr('left_index + '.$node_size)),
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '144', column '50').
Open

                              group_id IN ('.new Zend_Db_Expr(
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '712', column '23').
Open

            throw new Zend_Exception('Please set a name.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '269', column '23').
Open

            throw new Zend_Exception('Should be an user.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '580', column '39').
Open

            array('left_index' => new Zend_Db_Expr('left_index - 2')),
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '762', column '43').
Open

                array('left_index' => new Zend_Db_Expr('2 + left_index')),
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '672', column '40').
Open

            array('right_index' => new Zend_Db_Expr('right_index + '.$node_size)),
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '702', column '23').
Open

            throw new Zend_Exception('Should be a folder.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '400', column '23').
Open

            throw new Zend_Exception('Should be a folder');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getAllChildren has a boolean flag argument $admin, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getAllChildren($folder, $userDao, $admin = false, $policy = 0)
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '632', column '23').
Open

            throw new Zend_Exception('This name is already used');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '112', column '23').
Open

            throw new Zend_Exception('Error in params when checking Folder Policy.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '534', column '23').
Open

            throw new Zend_Exception('The dao should be saved first ...');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '607', column '23').
Open

            throw new Zend_Exception('Folder == Parent');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '645', column '37').
Open

                'left_index' => new Zend_Db_Expr('0 - left_index'),
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '360', column '60').
Open

                                        group_id IN ('.new Zend_Db_Expr(
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '531', column '23').
Open

            throw new Zend_Exception('Should be a folder');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '681', column '37').
Open

                'left_index' => new Zend_Db_Expr('0 - left_index + '.$cond),
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '937', column '47').
Open

                ).' OR ipg.group_id IN ('.new Zend_Db_Expr(
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1044', column '93').
Open

                'f.folder_id IN ('.new Zend_Db_Expr($usrSql).') OR '.'f.folder_id IN ('.new Zend_Db_Expr(
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1064', column '23').
Open

            throw new Zend_Exception('Should be a folder.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1113', column '23').
Open

            throw new Zend_Exception('Should be a folder.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '945', column '38').
Open

                'i.item_id IN ('.new Zend_Db_Expr($usrSql).') OR '.'i.item_id IN ('.new Zend_Db_Expr(
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getItemByName has a boolean flag argument $caseSensitive, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getItemByName($folder, $itemname, $caseSensitive = true)
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '1311', column '23').
Open

            throw new Zend_Exception('Should be a folder.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1556', column '39').
Open

            array('left_index' => new Zend_Db_Expr('2 + left_index')),
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '814', column '23').
Open

            throw new Zend_Exception('Should be a folder.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getFoldersFromSearch has a boolean flag argument $group, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getFoldersFromSearch($search, $userDao, $limit = 14, $group = true, $order = 'view')
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '1138', column '23').
Open

            throw new Zend_Exception('Should be a folder.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1044', column '40').
Open

                'f.folder_id IN ('.new Zend_Db_Expr($usrSql).') OR '.'f.folder_id IN ('.new Zend_Db_Expr(
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '945', column '89').
Open

                'i.item_id IN ('.new Zend_Db_Expr($usrSql).') OR '.'i.item_id IN ('.new Zend_Db_Expr(
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1442', column '41').
Open

            '(NOT f.parent_id IN ('.new Zend_Db_Expr(
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1036', column '47').
Open

                ).' OR fpg.group_id IN ('.new Zend_Db_Expr(
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1090', column '23').
Open

            throw new Zend_Exception('Should be an item.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1087', column '23').
Open

            throw new Zend_Exception('Should be a folder.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1116', column '23').
Open

            throw new Zend_Exception('Should be an item.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '789', column '23').
Open

            throw new Zend_Exception('Should be a folder.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1478', column '41').
Open

            '(NOT f.parent_id IN ('.new Zend_Db_Expr(
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1551', column '40').
Open

            array('right_index' => new Zend_Db_Expr('2 + right_index')),
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method addItem has a boolean flag argument $update, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addItem($folder, $item, $update = true)
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '1181', column '23').
Open

            throw new Zend_Exception('Should be an user.');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1232', column '58').
Open

                                  fpg.group_id IN ('.new Zend_Db_Expr(
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getSizeFiltered uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $userId = $userDao->getUserId();
            if ($userDao->isAdmin()) {
                $isAdmin = true;
            }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'UtilityComponent' in method 'save'.
Open

                $data[$key] = UtilityComponent::filterHtmlTags($folder->getDescription());
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'MidasLoader' in method 'delete'.
Open

            $this->Progress = MidasLoader::loadModel('Progress');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $parentFolder = $folder->getParent();
            if (!$parentFolder) {
                return false; // deleting orphaned folder
            }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            if (!isset($data['date_creation']) || empty($data['date_creation'])) {
                $data['date_creation'] = date('Y-m-d H:i:s');
            }
            $data['date_update'] = date('Y-m-d H:i:s');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method getAllChildren uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $userId = $userDao->getUserId();
            if ($userDao->isAdmin()) {
                $isAdmin = true;
            }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'MidasLoader' in method 'save'.
Open

            $uuidComponent = MidasLoader::loadComponent('Uuid');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method getMaxPolicy uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $userId = -1;
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'MidasLoader' in method 'delete'.
Open

        $policy_group_model = MidasLoader::loadModel('Folderpolicygroup');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method policyCheck uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $userId = $userDao->getUserId();
            if ($userDao->isAdmin()) {
                return true;
            }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'MidasLoader' in method 'delete'.
Open

        $policy_user_model = MidasLoader::loadModel('Folderpolicyuser');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method _recomputeSubtree uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $parentFolder = $folder->getParent();
            $rightParent = $parentFolder->getRightIndex();
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method getItemsFiltered uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $folderIds = array($folder->getKey());
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'MidasLoader' in method 'addItem'.
Open

        $itemModel = MidasLoader::loadModel('Item');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method zipStream uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                    } else {
                        $currPath = $path.'/'.$bitstream->getName();
                    }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'MidasLoader' in method 'zipStream'.
Open

        $this->Item = MidasLoader::loadModel('Item');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method getFoldersFromSearch uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $userId = $userDao->getUserId();
            if ($userDao->isAdmin()) {
                $isAdmin = true;
            }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'MidasLoader' in method 'removeOrphans'.
Open

            $this->Progress = MidasLoader::loadModel('Progress');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method getChildrenFoldersFiltered uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $folderIds = array($folder->getKey());
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'MidasLoader' in method 'removeItem'.
Open

            $itemModel = MidasLoader::loadModel('Item');
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method getFoldersFromSearch uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $sql->from(array('f' => 'folder'))->distinct();
            }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method zipStream uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else { // default behavior, just write out the file
                    if ($count > 1 || $bitstream->getName() != $item->getName()
                    ) {
                        $currPath = $path.'/'.$item->getName().'/'.$bitstream->getName();
                    } else {
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method getItemByName uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $row = $this->database->fetchRow(
                $this->database->select()->setIntegrityCheck(false)->from('item')->join(
                    'item2folder',
                    'item2folder.item_id = item.item_id'
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused local variables such as '$var'.
Open

        foreach ($this->_mainData as $key => $var) {
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function policyCheck($folderDao, $userDao = null, $policy = 0)
    {
        if (!$folderDao instanceof FolderDao || !is_numeric($policy)) {
            throw new Zend_Exception('Error in params when checking Folder Policy.');
        }
Severity: Major
Found in core/models/pdo/FolderModel.php and 2 other locations - About 2 days to fix
core/models/pdo/FeedModel.php on lines 65..113
core/models/pdo/ItemModel.php on lines 465..512

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 410.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function getMaxPolicy($folderId, $user)
    {
        $maxPolicy = -1;
        if ($user) {
            if ($user->isAdmin()) {
Severity: Major
Found in core/models/pdo/FolderModel.php and 1 other location - About 1 day to fix
core/models/pdo/ItemModel.php on lines 412..454

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 358.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (!$isAdmin) {
            $usrSql = $this->database->select()->setIntegrityCheck(false)->from(
                array('ipu' => 'itempolicyuser'),
                array('item_id')
            )->where('ipu.item_id = i.item_id')->where('ipu.user_id = ?', $userId)->where('policy >= ?', $policy);
Severity: Major
Found in core/models/pdo/FolderModel.php and 1 other location - About 1 day to fix
core/models/pdo/FolderModel.php on lines 1021..1048

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 287.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (!$isAdmin) {
            $usrSql = $this->database->select()->setIntegrityCheck(false)->from(
                array('fpu' => 'folderpolicyuser'),
                array('folder_id')
            )->where('fpu.folder_id = f.folder_id')->where('fpu.user_id = ?', $userId)->where('policy >= ?', $policy);
Severity: Major
Found in core/models/pdo/FolderModel.php and 1 other location - About 1 day to fix
core/models/pdo/FolderModel.php on lines 922..949

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 287.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (!$isAdmin) {
                $subqueryGroup->join(
                    array('fpg' => 'folderpolicygroup'),
                    '
                                f.folder_id = fpg.folder_id  AND '.$this->database->getDB()->quoteInto(
Severity: Major
Found in core/models/pdo/FolderModel.php and 1 other location - About 2 hrs to fix
core/models/pdo/FolderModel.php on lines 479..499

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (!$isAdmin) {
            $subqueryGroup->join(
                array('fpg' => 'folderpolicygroup'),
                '
                              f.folder_id = fpg.folder_id  AND '.$this->database->getDB()->quoteInto(
Severity: Major
Found in core/models/pdo/FolderModel.php and 1 other location - About 2 hrs to fix
core/models/pdo/FolderModel.php on lines 305..325

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function countOrphans()
    {
        $sql = $this->database->select()->setIntegrityCheck(false)->from(
            array('f' => 'folder'),
            array('count' => 'count(*)')
Severity: Major
Found in core/models/pdo/FolderModel.php and 1 other location - About 2 hrs to fix
core/models/pdo/BitstreamModel.php on lines 58..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function iterateWithCallback($callback, $paramName = 'folder', $otherParams = array())
    {
        $rowset = $this->database->fetchAll();
        foreach ($rowset as $row) {
            $folder = $this->initDao('Folder', $row);
Severity: Minor
Found in core/models/pdo/FolderModel.php and 1 other location - About 50 mins to fix
core/models/pdo/ItemModel.php on lines 664..672

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid excessively long variable names like $overrideOutputFunction. Keep variable name length under 20.
Open

    public function zipStream(&$zip, $path, $folder, &$userDao, &$overrideOutputFunction = null)
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class FolderModel extends FolderModelBase

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 24 and the first side effect is on line 21.
Open

<?php

Avoid variables with short names like $id. Configured minimum length is 3.
Open

        $id = $folder->getFolderId();
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $i. Configured minimum length is 3.
Open

        $i = 0;
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Method name "_recomputeSubtree" should not be prefixed with an underscore to indicate visibility
Open

    protected function _recomputeSubtree($folder, &$count, $max, $progressDao = null)

Method name "_buildChildFoldersQuery" should not be prefixed with an underscore to indicate visibility
Open

    private function _buildChildFoldersQuery(&$userDao, &$folderIds, $policy, $sortfield = 'name', $sortdir = 'asc')

Method name "_buildChildItemsQuery" should not be prefixed with an underscore to indicate visibility
Open

    private function _buildChildItemsQuery(&$userDao, &$folderIds, $policy, $sortfield = 'name', $sortdir = 'asc')

Line exceeds 120 characters; contains 151 characters
Open

        $cond = ($parent_pos_right > $node_pos_right) ? $parent_pos_right - $node_pos_right - 1 : $parent_pos_right - $node_pos_right - 1 + $node_size;

Line exceeds 120 characters; contains 133 characters
Open

        // This overrides *all* queries, not just specific ones, so at most one module per instance should be handling this callback.

Line exceeds 120 characters; contains 123 characters
Open

        // If a module wishes to override the default (slow) SQL-based item searching, it should register to this callback.

The variable $parent_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_pos_left is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policy_user_model is not named in camelCase.
Open

    public function delete($folder, $progressDao = null)
    {
        if (!$folder instanceof FolderDao) {
            throw new Zend_Exception('Should be a folder');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_size is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_size is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parent_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parent_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_size is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policy_group_model is not named in camelCase.
Open

    public function delete($folder, $progressDao = null)
    {
        if (!$folder instanceof FolderDao) {
            throw new Zend_Exception('Should be a folder');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parent_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parent_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policy_user_model is not named in camelCase.
Open

    public function delete($folder, $progressDao = null)
    {
        if (!$folder instanceof FolderDao) {
            throw new Zend_Exception('Should be a folder');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parent_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_pos_left is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_size is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_size is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_size is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_pos_left is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_pos_left is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $policy_group_model is not named in camelCase.
Open

    public function delete($folder, $progressDao = null)
    {
        if (!$folder instanceof FolderDao) {
            throw new Zend_Exception('Should be a folder');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $node_size is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parent_pos_right is not named in camelCase.
Open

    public function move($folder, $parent)
    {
        if ($folder->getKey() == $parent->getKey()) {
            throw new Zend_Exception('Folder == Parent');
        }
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method _buildChildFoldersQuery is not named in camelCase.
Open

    private function _buildChildFoldersQuery(&$userDao, &$folderIds, $policy, $sortfield = 'name', $sortdir = 'asc')
    {
        $userId = $userDao instanceof UserDao ? $userDao->getKey() : -1;
        $isAdmin = $userDao instanceof UserDao ? $userDao->isAdmin() : false;

Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _recomputeSubtree is not named in camelCase.
Open

    protected function _recomputeSubtree($folder, &$count, $max, $progressDao = null)
    {
        ++$count;
        if ($progressDao && $count % 10 == 0) { // only update progress every 10 folders
            $message = 'Rebuilding entire folder tree index ('.$count.'/'.$max.')';
Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _buildChildItemsQuery is not named in camelCase.
Open

    private function _buildChildItemsQuery(&$userDao, &$folderIds, $policy, $sortfield = 'name', $sortdir = 'asc')
    {
        $userId = $userDao instanceof UserDao ? $userDao->getKey() : -1;
        $isAdmin = $userDao instanceof UserDao ? $userDao->isAdmin() : false;

Severity: Minor
Found in core/models/pdo/FolderModel.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status