Sign upLogin

midasplatform/Midas

View on GitHub
Star
modules/javauploaddownload/java/upload/src/org/json/XML.java

Summary

Maintainability
F
1 wk
Test Coverage

Method parse has a Cognitive Complexity of 106 (exceeds 5 allowed). Consider refactoring.
Open

    private static boolean parse(XMLTokener x, JSONObject context,
                                 String name) throws JSONException {
        char       c;
        int        i;
        JSONObject jsonobject = null;
Severity: Minor
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method toString has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring.
Open

    public static String toString(Object object, String tagName)
            throws JSONException {
        StringBuffer sb = new StringBuffer();
        int          i;
        JSONArray    ja;
Severity: Minor
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has 123 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static boolean parse(XMLTokener x, JSONObject context,
                                 String name) throws JSONException {
        char       c;
        int        i;
        JSONObject jsonobject = null;
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 4 hrs to fix

File XML.java has 323 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package org.json;

/*
Copyright (c) 2002 JSON.org
Severity: Minor
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 3 hrs to fix

Method toString has 90 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static String toString(Object object, String tagName)
            throws JSONException {
        StringBuffer sb = new StringBuffer();
        int          i;
        JSONArray    ja;
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 3 hrs to fix

Method stringToValue has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public static Object stringToValue(String string) {
        if ("".equals(string)) {
            return string;
        }
        if ("true".equalsIgnoreCase(string)) {
Severity: Minor
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method stringToValue has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static Object stringToValue(String string) {
        if ("".equals(string)) {
            return string;
        }
        if ("true".equalsIgnoreCase(string)) {
Severity: Minor
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 1 hr to fix

Avoid deeply nested control flow statements.
Open

                        for (i = 0; i < length; i += 1) {
                            if (i > 0) {
                                sb.append('\n');
                            }
                            sb.append(escape(ja.get(i).toString()));
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 45 mins to fix

Avoid too many return statements within this method.
Open

            return new Integer(0);
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

                        return new Integer(myLong.intValue());
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

            return false;
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

                    return Double.valueOf(string);
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return string;
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

            return false;
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return string;
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

                    return false;
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

                        return myLong;
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

                        return false;
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java - About 30 mins to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

package org.json;

/*
Copyright (c) 2002 JSON.org
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XML.java and 1 other location - About 4 days to fix
modules/dicomanonymize/java/upload/src/org/json/XML.java on lines 1..508

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 2240.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status