Sign upLogin

midasplatform/Midas

View on GitHub
Star
modules/javauploaddownload/java/upload/src/org/json/XMLTokener.java

Summary

Maintainability
F
4 days
Test Coverage

Method nextToken has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public Object nextToken() throws JSONException {
        char c;
        char q;
        StringBuffer sb;
        do {
Severity: Minor
Found in modules/javauploaddownload/java/upload/src/org/json/XMLTokener.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method nextToken has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public Object nextToken() throws JSONException {
        char c;
        char q;
        StringBuffer sb;
        do {
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XMLTokener.java - About 2 hrs to fix

Method nextMeta has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public Object nextMeta() throws JSONException {
        char c;
        char q;
        do {
            c = next();
Severity: Minor
Found in modules/javauploaddownload/java/upload/src/org/json/XMLTokener.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method skipPast has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean skipPast(String to) throws JSONException {
        boolean b;
        char c;
        int i;
        int j;
Severity: Minor
Found in modules/javauploaddownload/java/upload/src/org/json/XMLTokener.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method nextMeta has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public Object nextMeta() throws JSONException {
        char c;
        char q;
        do {
            c = next();
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XMLTokener.java - About 2 hrs to fix

Method skipPast has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public boolean skipPast(String to) throws JSONException {
        boolean b;
        char c;
        int i;
        int j;
Severity: Minor
Found in modules/javauploaddownload/java/upload/src/org/json/XMLTokener.java - About 1 hr to fix

Method nextContent has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public Object nextContent() throws JSONException {
        char         c;
        StringBuffer sb;
        do {
            c = next();
Severity: Minor
Found in modules/javauploaddownload/java/upload/src/org/json/XMLTokener.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method nextEntity has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public Object nextEntity(char ampersand) throws JSONException {
        StringBuffer sb = new StringBuffer();
        for (;;) {
            char c = next();
            if (Character.isLetterOrDigit(c) || c == '#') {
Severity: Minor
Found in modules/javauploaddownload/java/upload/src/org/json/XMLTokener.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method nextCDATA has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public String nextCDATA() throws JSONException {
        char         c;
        int          i;
        StringBuffer sb = new StringBuffer();
        for (;;) {
Severity: Minor
Found in modules/javauploaddownload/java/upload/src/org/json/XMLTokener.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

package org.json;

/*
Copyright (c) 2002 JSON.org
Severity: Major
Found in modules/javauploaddownload/java/upload/src/org/json/XMLTokener.java and 1 other location - About 2 days to fix
modules/dicomanonymize/java/upload/src/org/json/XMLTokener.java on lines 1..365

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1347.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status