Sign upLogin

mikecbrant/php-rest-client

View on GitHub
Star

Showing 42 of 42 total issues

RestClient has 32 functions (exceeds 20 allowed). Consider refactoring.
Open

class RestClient
{
    /**
      * Flag to determine if basic authentication is to be used.
     *
Severity: Minor
Found in src/RestClientLib/RestClient.php - About 4 hrs to fix

    The class RestClient has an overall complexity of 63 which is very high. The configured complexity threshold is 50.
    Open

    class RestClient
{
    /**
      * Flag to determine if basic authentication is to be used.
     *
    Severity: Minor
    Found in src/RestClientLib/RestClient.php by phpmd

    File RestClient.php has 289 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace MikeBrant\RestClientLib;

/**
    Severity: Minor
    Found in src/RestClientLib/RestClient.php - About 2 hrs to fix

      Function setRemoteHost has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function setRemoteHost($host)
    {
        if(empty($host)) {
            throw new \InvalidArgumentException('Host name not provided.');
        } else if(!is_string($host)) {
      Severity: Minor
      Found in src/RestClientLib/RestClient.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid using undefined variables such as '$active' which will lead to PHP notices.
      Open

                  $status = curl_multi_exec($this->curlMultiHandle, $active);
      Severity: Minor
      Found in src/RestClientLib/RestMultiClient.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$active' which will lead to PHP notices.
      Open

              } while ($status === CURLM_CALL_MULTI_PERFORM || $active);
      Severity: Minor
      Found in src/RestClientLib/RestMultiClient.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Method curlInit has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function curlInit()
    {
        // initialize curl
        $curl = curl_init();
        if($curl === false) {
      Severity: Minor
      Found in src/RestClientLib/RestClient.php - About 1 hr to fix

        Function curlInit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function curlInit()
    {
        // initialize curl
        $curl = curl_init();
        if($curl === false) {
        Severity: Minor
        Found in src/RestClientLib/RestClient.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function validateGetinfoArray has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function validateGetinfoArray(array $getinfo)
    {
        if(empty($getinfo)) {
            throw new \InvalidArgumentException('Empty array passed. Valid curl_getinfo() result array expected.');
        }
        Severity: Minor
        Found in src/RestClientLib/CurlHttpResponse.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Missing class import via use statement (line '148', column '23').
        Open

                    throw new \InvalidArgumentException('curl_getinfo() response array expects string value at request_header key.');
        Severity: Minor
        Found in src/RestClientLib/CurlHttpResponse.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '228', column '23').
        Open

                    throw new \Exception('curl_multi_exec failed with status "' . $status . '"');
        Severity: Minor
        Found in src/RestClientLib/RestMultiClient.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '145', column '23').
        Open

                    throw new \InvalidArgumentException('curl_getinfo() response array expects string value at url key.');
        Severity: Minor
        Found in src/RestClientLib/CurlHttpResponse.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '214', column '23').
        Open

                    throw new \InvalidArgumentException('Host name not provided.');
        Severity: Minor
        Found in src/RestClientLib/RestClient.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '216', column '23').
        Open

                    throw new \InvalidArgumentException('Non-string host name provided.');
        Severity: Minor
        Found in src/RestClientLib/RestClient.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '295', column '23').
        Open

                    throw new \LengthException('The number of actions requested does not match the number of data elements provided.');
        Severity: Minor
        Found in src/RestClientLib/RestMultiClient.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '139', column '23').
        Open

                    throw new \InvalidArgumentException('curl_getinfo() response array expects integer value at http_code key.');
        Severity: Minor
        Found in src/RestClientLib/CurlHttpResponse.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '186', column '23').
        Open

                    throw new \Exception('multi_curl handle failed to initialize.');
        Severity: Minor
        Found in src/RestClientLib/RestMultiClient.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '334', column '23').
        Open

                    throw new \LengthException('Length of data array exceeds maxHandles setting.');
        Severity: Minor
        Found in src/RestClientLib/RestMultiClient.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '259', column '23').
        Open

                    throw new \InvalidArgumentException('URI base not provided.');
        Severity: Minor
        Found in src/RestClientLib/RestClient.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '282', column '23').
        Open

                    throw new \InvalidArgumentException('Non-boolean value passed as parameter.');
        Severity: Minor
        Found in src/RestClientLib/RestClient.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Severity
        Category
        Status
        Source
        Language