Sign upLogin

mikecbrant/php-rest-client

View on GitHub
Star

Showing 6 of 42 total issues

RestClient has 32 functions (exceeds 20 allowed). Consider refactoring.
Open

class RestClient
{
    /**
      * Flag to determine if basic authentication is to be used.
     *
Severity: Minor
Found in src/RestClientLib/RestClient.php - About 4 hrs to fix

    File RestClient.php has 289 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace MikeBrant\RestClientLib;

/**
    Severity: Minor
    Found in src/RestClientLib/RestClient.php - About 2 hrs to fix

      Function setRemoteHost has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function setRemoteHost($host)
    {
        if(empty($host)) {
            throw new \InvalidArgumentException('Host name not provided.');
        } else if(!is_string($host)) {
      Severity: Minor
      Found in src/RestClientLib/RestClient.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method curlInit has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function curlInit()
    {
        // initialize curl
        $curl = curl_init();
        if($curl === false) {
      Severity: Minor
      Found in src/RestClientLib/RestClient.php - About 1 hr to fix

        Function curlInit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function curlInit()
    {
        // initialize curl
        $curl = curl_init();
        if($curl === false) {
        Severity: Minor
        Found in src/RestClientLib/RestClient.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function validateGetinfoArray has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function validateGetinfoArray(array $getinfo)
    {
        if(empty($getinfo)) {
            throw new \InvalidArgumentException('Empty array passed. Valid curl_getinfo() result array expected.');
        }
        Severity: Minor
        Found in src/RestClientLib/CurlHttpResponse.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language