Sign upLogin

mikecbrant/php-ultimate-sessions

View on GitHub
Star
src/UltimateSessions/UltimateSessionManager.php

Summary

Maintainability
A
1 hr
Test Coverage
A
100%

Showing 3 of 22 total issues

regenerateId accesses the super-global variable $_SESSION.
Wontfix

    public function regenerateId()
    {
        $oldSessionId = $this->getSessionId();
        if (version_compare(PHP_VERSION, '7.1.0', '>=')) {
            $newSessionId = session_create_id();
Severity: Minor
Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

generateFingerprint accesses the super-global variable $_SERVER.
Wontfix

    protected function generateFingerprint()
    {
        $fingerprint = '';
        if(!empty($_SERVER['HTTP_USER_AGENT'])) {
            $fingerprint .= $_SERVER['HTTP_USER_AGENT'];
Severity: Minor
Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

generateFingerprint accesses the super-global variable $_SERVER.
Wontfix

    protected function generateFingerprint()
    {
        $fingerprint = '';
        if(!empty($_SERVER['HTTP_USER_AGENT'])) {
            $fingerprint .= $_SERVER['HTTP_USER_AGENT'];
Severity: Minor
Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

generateFingerprint accesses the super-global variable $_SERVER.
Wontfix

    protected function generateFingerprint()
    {
        $fingerprint = '';
        if(!empty($_SERVER['HTTP_USER_AGENT'])) {
            $fingerprint .= $_SERVER['HTTP_USER_AGENT'];
Severity: Minor
Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

writeMetadata accesses the super-global variable $_SESSION.
Wontfix

    protected function writeMetadata() {
        $_SESSION[self::METADATA_KEY] = $this->metadata;
    }
Severity: Minor
Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

startSession accesses the super-global variable $_SESSION.
Wontfix

    public function startSession()
    {
        $result = session_start();
        if ($result === false) {
            throw new \RuntimeException('session_start() unexpectedly failed.');
Severity: Minor
Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

regenerateId accesses the super-global variable $_COOKIE.
Wontfix

    public function regenerateId()
    {
        $oldSessionId = $this->getSessionId();
        if (version_compare(PHP_VERSION, '7.1.0', '>=')) {
            $newSessionId = session_create_id();
Severity: Minor
Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

startSession accesses the super-global variable $_SESSION.
Wontfix

    public function startSession()
    {
        $result = session_start();
        if ($result === false) {
            throw new \RuntimeException('session_start() unexpectedly failed.');
Severity: Minor
Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

generateFingerprint accesses the super-global variable $_SERVER.
Wontfix

    protected function generateFingerprint()
    {
        $fingerprint = '';
        if(!empty($_SERVER['HTTP_USER_AGENT'])) {
            $fingerprint .= $_SERVER['HTTP_USER_AGENT'];
Severity: Minor
Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

generateFingerprint accesses the super-global variable $_SERVER.
Wontfix

    protected function generateFingerprint()
    {
        $fingerprint = '';
        if(!empty($_SERVER['HTTP_USER_AGENT'])) {
            $fingerprint .= $_SERVER['HTTP_USER_AGENT'];
Severity: Minor
Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

regenerateId accesses the super-global variable $_SESSION.
Wontfix

    public function regenerateId()
    {
        $oldSessionId = $this->getSessionId();
        if (version_compare(PHP_VERSION, '7.1.0', '>=')) {
            $newSessionId = session_create_id();
Severity: Minor
Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

destroySession accesses the super-global variable $_SESSION.
Wontfix

    public function destroySession()
    {
        $_SESSION = [];
        $this->executeGcNotificationCallback($this->getSessionId(), time());
        session_destroy();
Severity: Minor
Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

forwardSession accesses the super-global variable $_COOKIE.
Wontfix

    protected function forwardSession($newSessionId)
    {
        $oldSessionId = $this->getSessionId();
        $this->commitSession();
        ini_set('session.use_strict_mode', 0);
Severity: Minor
Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

generateFingerprint accesses the super-global variable $_SERVER.
Wontfix

    protected function generateFingerprint()
    {
        $fingerprint = '';
        if(!empty($_SERVER['HTTP_USER_AGENT'])) {
            $fingerprint .= $_SERVER['HTTP_USER_AGENT'];
Severity: Minor
Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

Method regenerateId has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function regenerateId()
    {
        $oldSessionId = $this->getSessionId();
        if (version_compare(PHP_VERSION, '7.1.0', '>=')) {
            $newSessionId = session_create_id();
Severity: Minor
Found in src/UltimateSessions/UltimateSessionManager.php - About 1 hr to fix

    Missing class import via use statement (line '150', column '23').
    Open

                throw new \RuntimeException('session_start() unexpectedly failed.');
    Severity: Minor
    Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

    Missing class import via use statement (line '348', column '23').
    Open

                throw new \RuntimeException(
    Severity: Minor
    Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

    The method regenerateId uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Wontfix

            } else {
                session_regenerate_id(false);
                $newSessionId = $this->getSessionId();
                $this->commitSession();
                ini_set('session.use_strict_mode', 0);
    Severity: Minor
    Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

    Avoid excessively long variable names like $gcNotificationCallback. Keep variable name length under 20.
    Wontfix

        protected $gcNotificationCallback;
    Severity: Minor
    Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

    Avoid excessively long variable names like $gcNotificationCallback. Keep variable name length under 20.
    Wontfix

            callable $gcNotificationCallback = null,
    Severity: Minor
    Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

    Avoid excessively long variable names like $sessionIdChangeCallback. Keep variable name length under 20.
    Wontfix

        protected $sessionIdChangeCallback;
    Severity: Minor
    Found in src/UltimateSessions/UltimateSessionManager.php by phpmd

    Avoid excessively long variable names like $sessionIdChangeCallback. Keep variable name length under 20.
    Wontfix

            callable $sessionIdChangeCallback = null,
    Severity: Minor
    Found in src/UltimateSessions/UltimateSessionManager.php by phpmd
    Category
    Status