Sign upLogin

mikelkew/money-transferwise-bank

View on GitHub
Star
lib/money/bank/transferwise_bank.rb

Summary

Maintainability
A
1 hr
Test Coverage

Class TransferwiseBank has 28 methods (exceeds 20 allowed). Consider refactoring.
Wontfix

    class TransferwiseBank < Money::Bank::VariableExchange
      # TransferwiseBank url components
      TW_SERVICE_HOST = 'api.transferwise.com'
      TW_SERVICE_PATH = '/v1/rates'
Severity: Minor
Found in lib/money/bank/transferwise_bank.rb - About 3 hrs to fix

    Method update_rates has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def update_rates(straight = false)
        new_rates = exchange_rates(straight)

        unless new_rates.is_a?(Array)
          return unless raise_on_failure
    Severity: Minor
    Found in lib/money/bank/transferwise_bank.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status