Sign upLogin

mingujo/UCBerkeley_Housing

View on GitHub
Star
app/controllers/events_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Method destroy has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  def destroy
    @event = Event.find_by_id(params[:id])
    if params[:delete_all] == "true"
      events = Event.where(:event_series_id => @event.event_series_id)
      for event in events
Severity: Minor
Found in app/controllers/events_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    if params[:event][:period] == "Does not repeat"
      event = Event.new(event_params)
    else
      event = EventSeries.new(event_params)
Severity: Minor
Found in app/controllers/events_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def update
    @event = Event.find_by_id(params[:id])
    ts = Timeslot.find_by_starttime_and_ca_id(@event.start_time, @event.ca_id)
    @event.attributes = event_params
    if @event.attributes["end_time"] - @event.attributes["start_time"] != @@THIRTY_MIN
Severity: Minor
Found in app/controllers/events_controller.rb - About 1 hr to fix

    Method update has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def update
    @event = Event.find_by_id(params[:id])
    ts = Timeslot.find_by_starttime_and_ca_id(@event.start_time, @event.ca_id)
    @event.attributes = event_params
    if @event.attributes["end_time"] - @event.attributes["start_time"] != @@THIRTY_MIN
    Severity: Minor
    Found in app/controllers/events_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def create
    if params[:event][:period] == "Does not repeat"
      event = Event.new(event_params)
    else
      event = EventSeries.new(event_params)
    Severity: Minor
    Found in app/controllers/events_controller.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status