Sign upLogin

ministryofjustice/Claim-for-Crown-Court-Defence

View on GitHub
Star
app/models/claim/transfer_brain/data_item.rb

Summary

Maintainability
A
2 hrs
Test Coverage
A
100%

Method equal_for_scheme_ten has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def equal_for_scheme_ten(other)
        return true unless other.fee_scheme_version == 10
        return false if elected_case

        if other.elected_case
Severity: Minor
Found in app/models/claim/transfer_brain/data_item.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method == has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def ==(other)
        return false unless litigator_type == other.litigator_type
        return false unless equal_for_scheme_nine(other)
        return false unless equal_for_scheme_ten(other)
        return false unless transfer_stage_id == other.transfer_stage_id
Severity: Minor
Found in app/models/claim/transfer_brain/data_item.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method equal_for_scheme_nine has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def equal_for_scheme_nine(other)
        return true unless other.fee_scheme_version == 9
        return false unless elected_case == other.elected_case
        return false unless elected_case || conclusion == other.conclusion
Severity: Minor
Found in app/models/claim/transfer_brain/data_item.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status