Sign upLogin

ministryofjustice/Claim-for-Crown-Court-Defence

View on GitHub
Star
app/models/concerns/softly_deletable.rb

Summary

Maintainability
A
1 hr
Test Coverage
C
72%

Method soft_delete has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def soft_delete
      transaction do
        before_soft_delete if respond_to?(:before_soft_delete)
        result = if is_a?(Claim::BaseClaim)
                   update_attribute(:deleted_at, Time.zone.now)
Severity: Minor
Found in app/models/concerns/softly_deletable.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method un_soft_delete has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Wontfix

    def un_soft_delete
      transaction do
        before_un_soft_delete if respond_to?(:before_un_soft_delete)
        result = if is_a?(Claim::BaseClaim)
                   update_attribute(:deleted_at, nil)
Severity: Minor
Found in app/models/concerns/softly_deletable.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status