Sign upLogin

ministryofjustice/Claim-for-Crown-Court-Defence

View on GitHub
Star
app/services/claims/fetch_eligible_misc_fee_types.rb

Summary

Maintainability
A
1 hr
Test Coverage
A
100%

Avoid too many return statements within this method.
Open

      return Fee::MiscFeeType.agfs_scheme_12s if agfs_scheme_12?
Severity: Major
Found in app/services/claims/fetch_eligible_misc_fee_types.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return Fee::MiscFeeType.agfs_scheme_10s if agfs_reform?
    Severity: Major
    Found in app/services/claims/fetch_eligible_misc_fee_types.rb - About 30 mins to fix

      Method agfs_scheme_scope has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def agfs_scheme_scope
      return Fee::MiscFeeType.agfs_scheme_16s if agfs_scheme_16?
      return Fee::MiscFeeType.agfs_scheme_15s if agfs_scheme_15?
      return Fee::MiscFeeType.agfs_scheme_14s if agfs_scheme_14?
      return Fee::MiscFeeType.agfs_scheme_13s if agfs_scheme_13?
      Severity: Minor
      Found in app/services/claims/fetch_eligible_misc_fee_types.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status