Sign upLogin

ministryofjustice/atet

View on GitHub
Star
app/validators/date_validator.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method illegal_date? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def illegal_date?(record, attribute, value)
    # The date type in rails seems a bit basic in terms of validation - it will accept 31/2/xxxx but not 32/2/xxxx,
    #   neither of which should be valid so we are going to validate better here.
    raw_value = read_attribute_before_type_cast(record, attribute, default: nil)
    if raw_value.is_a?(String) && raw_value.blank?
Severity: Minor
Found in app/validators/date_validator.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method illegal_year? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def illegal_year?(value)
    # Needs to verify that four digits are given for a year
    return false if value.nil?

    case value
Severity: Minor
Found in app/validators/date_validator.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status