Sign upLogin

ministryofjustice/govuk_elements_form_builder

View on GitHub
Star
lib/govuk_elements_form_builder/form_builder.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class FormBuilder has 37 methods (exceeds 20 allowed). Consider refactoring.
Open

  class FormBuilder < ActionView::Helpers::FormBuilder

    ActionView::Base.field_error_proc = Proc.new do |html_tag, instance|
      add_error_to_html_tag! html_tag, instance
    end
Severity: Minor
Found in lib/govuk_elements_form_builder/form_builder.rb - About 4 hrs to fix

    File form_builder.rb has 306 lines of code (exceeds 300 allowed). Consider refactoring.
    Wontfix

    module GovukElementsFormBuilder
  class FormBuilder < ActionView::Helpers::FormBuilder

    ActionView::Base.field_error_proc = Proc.new do |html_tag, instance|
      add_error_to_html_tag! html_tag, instance
    Severity: Minor
    Found in lib/govuk_elements_form_builder/form_builder.rb - About 2 hrs to fix

      Method collection_select has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def collection_select method, collection, value_method, text_method, options = {}, *args
      Severity: Minor
      Found in lib/govuk_elements_form_builder/form_builder.rb - About 45 mins to fix

        Method collection_radio_buttons has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Wontfix

            def collection_radio_buttons method, collection, value_method, text_method, options = {}, *args
        Severity: Minor
        Found in lib/govuk_elements_form_builder/form_builder.rb - About 45 mins to fix

          Method collection_check_boxes has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Wontfix

              def collection_check_boxes  method, collection, value_method, text_method, options = {}, *args
          Severity: Minor
          Found in lib/govuk_elements_form_builder/form_builder.rb - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Wontfix

                def collection_check_boxes  method, collection, value_method, text_method, options = {}, *args
      content_tag :div,
                  class: form_group_classes(method),
                  id: form_group_id(method) do
        content_tag :fieldset, fieldset_options(method, options) do
            Severity: Minor
            Found in lib/govuk_elements_form_builder/form_builder.rb and 1 other location - About 45 mins to fix
            lib/govuk_elements_form_builder/form_builder.rb on lines 106..121

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Wontfix

                def collection_radio_buttons method, collection, value_method, text_method, options = {}, *args
      content_tag :div,
                  class: form_group_classes(method),
                  id: form_group_id(method) do
        content_tag :fieldset, fieldset_options(method, options) do
            Severity: Minor
            Found in lib/govuk_elements_form_builder/form_builder.rb and 1 other location - About 45 mins to fix
            lib/govuk_elements_form_builder/form_builder.rb on lines 87..101

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status