Sign upLogin

ministryofjustice/hwf-calculator

View on GitHub
Star
test_common/sections/previous_questions.rb

Summary

Maintainability
A
0 mins
Test Coverage

Complex method Calculator::Test::PreviousQuestionsSection::section#has_answered? (48.9)
Wontfix

          def has_answered?(total_income)
            has_answer?(text: number_to_currency(total_income, precision: 0, unit: '£'))
Severity: Minor
Found in test_common/sections/previous_questions.rb by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

Similar blocks of code found in 2 locations. Consider refactoring.
Wontfix

        section :partner_date_of_birth, :calculator_previous_question, t('hwf_components.previous_questions.partner_date_of_birth.label') do
          @i18n_scope = "#{scope}.partner_date_of_birth"
          include ::Calculator::Test::PreviousQuestionSection

          def has_answered?(dob_text)
Severity: Minor
Found in test_common/sections/previous_questions.rb and 1 other location - About 35 mins to fix
test_common/sections/previous_questions.rb on lines 32..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Wontfix

        section :date_of_birth, :calculator_previous_question, t('hwf_components.previous_questions.date_of_birth.label') do
          @i18n_scope = "#{scope}.date_of_birth"
          include ::Calculator::Test::PreviousQuestionSection

          def has_answered?(dob_text)
Severity: Minor
Found in test_common/sections/previous_questions.rb and 1 other location - About 35 mins to fix
test_common/sections/previous_questions.rb on lines 42..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Wontfix

        section :court_fee, :calculator_previous_question, t('hwf_components.previous_questions.court_fee.label') do
          @i18n_scope = "#{scope}.court_fee"
          include ::Calculator::Test::PreviousQuestionSection
          include ActiveSupport::NumberHelper
Severity: Minor
Found in test_common/sections/previous_questions.rb and 2 other locations - About 25 mins to fix
test_common/sections/previous_questions.rb on lines 52..58
test_common/sections/previous_questions.rb on lines 81..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Wontfix

        section :disposable_capital, :calculator_previous_question, t('hwf_components.previous_questions.disposable_capital.label') do
          @i18n_scope = "#{scope}.disposable_capital"
          include ::Calculator::Test::PreviousQuestionSection
          include ActiveSupport::NumberHelper
Severity: Minor
Found in test_common/sections/previous_questions.rb and 2 other locations - About 25 mins to fix
test_common/sections/previous_questions.rb on lines 22..28
test_common/sections/previous_questions.rb on lines 81..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Wontfix

        section :total_income, :calculator_previous_question, t('hwf_components.previous_questions.total_income.label') do
          @i18n_scope = "#{scope}.total_income"
          include ::Calculator::Test::PreviousQuestionSection
          include ActiveSupport::NumberHelper
Severity: Minor
Found in test_common/sections/previous_questions.rb and 2 other locations - About 25 mins to fix
test_common/sections/previous_questions.rb on lines 22..28
test_common/sections/previous_questions.rb on lines 52..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status