Sign upLogin

ministryofjustice/moj-product-dashboard

View on GitHub
Star
dashboard/apps/dashboard/models/cost.py

Summary

Maintainability
A
1 hr
Test Coverage

Function get_costs_between has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def get_costs_between(self, start_date, end_date, name=None,
Severity: Minor
Found in dashboard/apps/dashboard/models/cost.py - About 35 mins to fix

    Function additional_costs has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def additional_costs(self, start_date, end_date, name=None,
    Severity: Minor
    Found in dashboard/apps/dashboard/models/cost.py - About 35 mins to fix

      Function rate_between has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def rate_between(self, start_date, end_date):
        if not self.end_date:
            if self.type == COST_TYPES.MONTHLY:
                cost_end_date = self.start_date + relativedelta(months=1)
            elif self.type == COST_TYPES.ANNUALLY:
      Severity: Minor
      Found in dashboard/apps/dashboard/models/cost.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status