Sign upLogin

ministryofjustice/moj-product-dashboard

View on GitHub
Star
dashboard/libs/date_tools.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function get_overlap has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def get_overlap(time_window0, time_window1):
    """
    get the overlap of two time windows
    :param time_window0: a tuple of date/datetime objects represeting the
    start and end of a time window
Severity: Minor
Found in dashboard/libs/date_tools.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function dates_between has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def dates_between(start_date, end_date, freq, bymonthday=None, bysetpos=None,
Severity: Minor
Found in dashboard/libs/date_tools.py - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status