Sign upLogin

ministryofjustice/peoplefinder

View on GitHub
Star
app/assets/javascripts/modules/team_selector.js

Summary

Maintainability
F
4 days
Test Coverage

Function teamSelector has 325 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var teamSelector = function teamSelector(isPerson, obj) {

  this.isPerson = isPerson;
  this.selector = $(obj);
  this.orgBrowser = this.selector.find('.org-browser');
Severity: Major
Found in app/assets/javascripts/modules/team_selector.js - About 1 day to fix

    Function teamSelector has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
    Open

    var teamSelector = function teamSelector(isPerson, obj) {

  this.isPerson = isPerson;
  this.selector = $(obj);
  this.orgBrowser = this.selector.find('.org-browser');
    Severity: Minor
    Found in app/assets/javascripts/modules/team_selector.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function initEvents has 119 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      this.initEvents = function() {

    var self = this;
    if (this.isPerson) {
      teamName = this.selector.find('.editable-summary ol li:last-child').text();
    Severity: Major
    Found in app/assets/javascripts/modules/team_selector.js - About 4 hrs to fix

      File team_selector.js has 336 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      var teamSelector = function teamSelector(isPerson, obj) {

  this.isPerson = isPerson;
  this.selector = $(obj);
  this.orgBrowser = this.selector.find('.org-browser');
      Severity: Minor
      Found in app/assets/javascripts/modules/team_selector.js - About 4 hrs to fix

        Function createNewTeam has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          this.createNewTeam = function() {

    var self = this,
      input = this.orgBrowser.find('input:checked'),
      teamId = input.val(),
        Severity: Minor
        Found in app/assets/javascripts/modules/team_selector.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                        return false;
          Severity: Major
          Found in app/assets/javascripts/modules/team_selector.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                      return false;
            Severity: Major
            Found in app/assets/javascripts/modules/team_selector.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                            return false;
              Severity: Major
              Found in app/assets/javascripts/modules/team_selector.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                              return false;
                Severity: Major
                Found in app/assets/javascripts/modules/team_selector.js - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      this.orgBrowser.on('click', 'li:not(.disabled) .subteam-link', function(e) {

      self.onClick(e);
      self.currentTarget = $(e.currentTarget);
      self.forward();
                  Severity: Major
                  Found in app/assets/javascripts/modules/team_selector.js and 1 other location - About 1 hr to fix
                  app/assets/javascripts/modules/team_selector.js on lines 43..48

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 67.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      this.orgBrowser.on('click', '.team-back', function(e) {

      self.onClick(e);
      self.currentTarget = $(e.currentTarget);
      self.back();
                  Severity: Major
                  Found in app/assets/javascripts/modules/team_selector.js and 1 other location - About 1 hr to fix
                  app/assets/javascripts/modules/team_selector.js on lines 52..57

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 67.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status