Sign upLogin

ministryofjustice/peoplefinder

View on GitHub
Star

Showing 24 of 24 total issues

Function teamSelector has 325 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var teamSelector = function teamSelector(isPerson, obj) {

  this.isPerson = isPerson;
  this.selector = $(obj);
  this.orgBrowser = this.selector.find('.org-browser');
Severity: Major
Found in app/assets/javascripts/modules/team_selector.js - About 1 day to fix

    Function teamSelector has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
    Open

    var teamSelector = function teamSelector(isPerson, obj) {

  this.isPerson = isPerson;
  this.selector = $(obj);
  this.orgBrowser = this.selector.find('.org-browser');
    Severity: Minor
    Found in app/assets/javascripts/modules/team_selector.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function initEvents has 119 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      this.initEvents = function() {

    var self = this;
    if (this.isPerson) {
      teamName = this.selector.find('.editable-summary ol li:last-child').text();
    Severity: Major
    Found in app/assets/javascripts/modules/team_selector.js - About 4 hrs to fix

      File team_selector.js has 336 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      var teamSelector = function teamSelector(isPerson, obj) {

  this.isPerson = isPerson;
  this.selector = $(obj);
  this.orgBrowser = this.selector.find('.org-browser');
      Severity: Minor
      Found in app/assets/javascripts/modules/team_selector.js - About 4 hrs to fix

        Class PersonSearch has 24 methods (exceeds 20 allowed). Consider refactoring.
        Open

        class PersonSearch
  attr_reader :query, :results, :matches

  PRE_TAGS = ['<span class="es-highlight">'].freeze
  POST_TAGS = ["</span>"].freeze
        Severity: Minor
        Found in app/services/person_search.rb - About 2 hrs to fix

          Class Group has 22 methods (exceeds 20 allowed). Consider refactoring.
          Open

          class Group < ApplicationRecord
  include Hierarchical
  include Placeholder

  MAX_DESCRIPTION = 2000
          Severity: Minor
          Found in app/models/group.rb - About 2 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                this.orgBrowser.on('click', 'li:not(.disabled) .subteam-link', function(e) {

      self.onClick(e);
      self.currentTarget = $(e.currentTarget);
      self.forward();
            Severity: Major
            Found in app/assets/javascripts/modules/team_selector.js and 1 other location - About 1 hr to fix
            app/assets/javascripts/modules/team_selector.js on lines 43..48

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 67.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                this.orgBrowser.on('click', '.team-back', function(e) {

      self.onClick(e);
      self.currentTarget = $(e.currentTarget);
      self.back();
            Severity: Major
            Found in app/assets/javascripts/modules/team_selector.js and 1 other location - About 1 hr to fix
            app/assets/javascripts/modules/team_selector.js on lines 52..57

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 67.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function createNewTeam has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              this.createNewTeam = function() {

    var self = this,
      input = this.orgBrowser.find('input:checked'),
      teamId = input.val(),
            Severity: Minor
            Found in app/assets/javascripts/modules/team_selector.js - About 1 hr to fix

              Function labelLoadTime has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  labelLoadTime: function(loadTime) {
        with(this)
            return     loadTime < 1 ? labels.excellent : 
                             loadTime < 2 ? labels.veryGood : 
                             loadTime < 3 ? labels.acceptable :
              Severity: Minor
              Found in app/assets/javascripts/modules/moj.Module.loadtime.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method format has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def format(raw_changes)
    raw_changes.inject({}) { |memo, (field, raw_change)|
      next memo unless changed? raw_change

      if work_days? field
              Severity: Minor
              Found in app/presenters/person_changes_presenter.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method eliminate_noops has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def eliminate_noops(changes)
    copy_changes = {}
    changes.each do |field, changeset|
      if membership_field?(field)
        copy_changes[field] = eliminate_noops(changes[field])
              Severity: Minor
              Found in app/services/profile_change_aggregator.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method validate_each has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def validate_each(record, attribute, value)
    email_address = EmailAddress.new(value)
    if value.present?
      if email_address.valid_format?
        unless email_address.permitted_domain?
              Severity: Minor
              Found in app/validators/email_validator.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method method_missing has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def method_missing method_name, *args # rubocop:disable Style/MissingRespondToMissing
    @method_name = method_name
    if valid_missing_method
      if raw_changes.key?(attribute_name_from_method)
        change = change(raw_changes[attribute_name_from_method])
              Severity: Minor
              Found in app/presenters/membership_change_set.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method crop has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def crop(x, y, w, h, versions = []) # rubocop:disable Naming/MethodParameterName
              Severity: Minor
              Found in app/models/profile_photo.rb - About 35 mins to fix

                Method confirm_or_create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    def confirm_or_create(person)
      @person = person
      @person.skip_must_have_team = true
      if @person.valid?
        if namesakes?
                Severity: Minor
                Found in app/controllers/concerns/session_person_creator.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                  def check_box(method, options = {}, checked_value = "1", unchecked_value = "0")
    @template.content_tag :div, class: "form-group" do
      @template.label(@object_name, method, class: "block-label selection-button-checkbox") do
        @template.check_box(@object_name, method.to_s, options, checked_value, unchecked_value) +
          label_t(method)
                Severity: Minor
                Found in app/form_builders/person_form_builder.rb and 1 other location - About 35 mins to fix
                app/form_builders/suggestion_form_builder.rb on lines 2..6

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                  def check_box(method, options = {}, checked_value = "1", unchecked_value = "0")
    @template.content_tag :div, class: "form-group" do
      @template.label(@object_name, method, class: "block-label selection-button-checkbox") do
        @template.check_box(@object_name, method.to_s, options, checked_value, unchecked_value) +
          label_t(method)
                Severity: Minor
                Found in app/form_builders/suggestion_form_builder.rb and 1 other location - About 35 mins to fix
                app/form_builders/person_form_builder.rb on lines 4..8

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid too many return statements within this function.
                Open

                              return false;
                Severity: Major
                Found in app/assets/javascripts/modules/team_selector.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                return false;
                  Severity: Major
                  Found in app/assets/javascripts/modules/team_selector.js - About 30 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language