Sign upLogin

miquido/data-structure

View on GitHub
Star

Showing 53 of 55 total issues

The method bool has a boolean flag argument $parseString, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function bool(bool $parseString = true): bool;
Severity: Minor
Found in src/Value/ValueInterface.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method toCollectionValue has a boolean flag argument $castScalar, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function toCollectionValue(bool $castScalar = true): CollectionValueInterface;
Severity: Minor
Found in src/Value/ValueInterface.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '234', column '19').
Open

        throw new \LogicException(\sprintf('%s - method not allowed. Please use "set" method.', __METHOD__));
Severity: Minor
Found in src/Map/Map.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '100', column '20').
Open

        return new \ArrayIterator($this->data);
Severity: Minor
Found in src/Value/Collection/CollectionValue.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method integers has a boolean flag argument $forceCast, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function integers(bool $forceCast = true): IntegerCollectionInterface;
Severity: Minor
Found in src/Value/Collection/CollectionValueInterface.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Remove error control operator '@' on line 54.
Open

    public function split(string $delimiter, int $limit = null): StringCollectionInterface
    {
        $limit = \is_int($limit) ? $limit : \PHP_INT_MAX;
        $strings = @\explode($delimiter, $this->value, $limit);
        if (false === $strings) {
Severity: Minor
Found in src/Value/Scalar/String/StringValue.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Missing class import via use statement (line '56', column '23').
Open

            throw new \InvalidArgumentException(\sprintf('Could not explode a string "%s" by "%s"', $this->value, $delimiter));
Severity: Minor
Found in src/Value/Scalar/String/StringValue.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method bool has a boolean flag argument $parseString, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function bool(bool $parseString = true): bool
Severity: Minor
Found in src/Value/Value.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '250', column '20').
Open

        return new \ArrayIterator($this->data);
Severity: Minor
Found in src/Map/Map.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method int has a boolean flag argument $forceCast, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function int(bool $forceCast = true): int;
Severity: Minor
Found in src/Value/Scalar/ScalarValueInterface.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method get has a boolean flag argument $nullDefault, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function get(string $key, $default = null, bool $nullDefault = false);
Severity: Minor
Found in src/Map/MapInterface.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method integers has a boolean flag argument $forceCast, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function integers(bool $forceCast = true): IntegerCollectionInterface
Severity: Minor
Found in src/Value/Collection/CollectionValue.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '64', column '24').
Open

            return new \DateTime($this->value);
Severity: Minor
Found in src/Value/Scalar/ScalarValue.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '62', column '19').
Open

        throw new \OutOfBoundsException(\sprintf('Key "%s" does not exist', $key));
Severity: Minor
Found in src/Map/Map.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '118', column '23').
Open

            throw new \InvalidArgumentException(\sprintf('Key "%s" already exists', $newName));
Severity: Minor
Found in src/Map/Map.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getValue has a boolean flag argument $nullDefault, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getValue(string $key, $default = null, bool $nullDefault = false): ValueInterface
Severity: Minor
Found in src/Map/Map.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '194', column '27').
Open

                throw new \LogicException(\sprintf('Duplicated key "%s"', $mappedKey));
Severity: Minor
Found in src/Map/Map.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '164', column '20').
Open

        return new \ArrayIterator($this->strings);
Severity: Minor
Found in src/TypedCollection/StringCollection.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method get has a boolean flag argument $nullDefault, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function get(string $key, $default = null, bool $nullDefault = false)
Severity: Minor
Found in src/Map/Map.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method int has a boolean flag argument $forceCast, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function int(bool $forceCast = true): int
Severity: Minor
Found in src/Value/Scalar/ScalarValue.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Severity
Category
Status
Source
Language