miquido/data-structure

View on GitHub
src/Value/Scalar/ScalarValue.php

Summary

Maintainability
A
0 mins
Test Coverage

The method bool has a boolean flag argument $parseString, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function bool(bool $parseString = true): bool
Severity: Minor
Found in src/Value/Scalar/ScalarValue.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '68', column '24').
Open

            return new \DateTime(\date('Y-m-d H:i:s', $this->value));
Severity: Minor
Found in src/Value/Scalar/ScalarValue.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '64', column '24').
Open

            return new \DateTime($this->value);
Severity: Minor
Found in src/Value/Scalar/ScalarValue.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method int has a boolean flag argument $forceCast, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function int(bool $forceCast = true): int
Severity: Minor
Found in src/Value/Scalar/ScalarValue.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '71', column '19').
Open

        throw new \InvalidArgumentException(\sprintf('Could not transform %s to DateTime', \gettype($this->value)));
Severity: Minor
Found in src/Value/Scalar/ScalarValue.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

There are no issues that match your filters.

Category
Status