Sign upLogin

mishina2228/oanda-api-rails

View on GitHub
Star

Showing 9 of 9 total issues

Method merge_into has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def merge_into(bidasks, midpoints)
      candles = bidasks.map do |bidask|
        midpoint = midpoints.find {|mid| mid.time == bidask.time}
        unless midpoint
          Rails.logger.info "Skip because time of bidask and midpoint did not match. time: #{bidask.time}"
Severity: Minor
Found in app/models/concerns/candle_concern.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  window.fetch('/resque_schedules/schedule')
    .then(response => {
      if (!response.ok) {
        throw new Error(`${response.status} ${response.statusText}`)
      }
Severity: Major
Found in app/javascript/controllers/resque_schedules.js and 1 other location - About 1 hr to fix
app/javascript/controllers/candle_access.js on lines 21..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method perform has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.perform(klass, params = {})
    raise 'Class must be specified.' if klass.blank?
    raise 'Class must be some candle-ish.' unless klass.include?(CandleConcern)

    params = params.with_indifferent_access
Severity: Minor
Found in app/jobs/candle_job.rb - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        Shared.sendAction(form, payload)
      .then(response => {
        if (!response.ok) {
          throw new Error(`${response.status} ${response.statusText}`)
        }
    Severity: Major
    Found in app/javascript/controllers/candle_access.js and 1 other location - About 1 hr to fix
    app/javascript/controllers/resque_schedules.js on lines 6..12

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method gimme_candle has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def gimme_candle(start:, count:)
      start = convert_time(start)
      count ||= 100
      unless count.between?(1, 5000)
        message = 'The value specified is not in the valid range: ' \
    Severity: Minor
    Found in app/models/concerns/candle_concern.rb - About 1 hr to fix

      Method perform has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.perform(klass, params = {})
    raise 'Class must be specified.' if klass.blank?
    raise 'Class must be some candle-ish.' unless klass.include?(CandleConcern)

    params = params.with_indifferent_access
      Severity: Minor
      Found in app/jobs/candle_job.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method before_enqueue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.before_enqueue(params = {})
    params = params.with_indifferent_access
    jobs = JobUtils.peek(@queue, 0, 100)
    jobs.each do |job|
      next if job['class'] != name
      Severity: Minor
      Found in app/jobs/candle_job.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method save_numerous_candles has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def save_numerous_candles(start:, finish:, count:)
      loop do
        if start >= finish
          Rails.logger.info "Exceeded finish: #{finish.in_time_zone('Asia/Tokyo')}. Finish the process."
          break
      Severity: Minor
      Found in app/models/concerns/candle_concern.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method arrange_params has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.arrange_params(klass, params)
    start = if params[:start]
              params[:start].to_time
            elsif klass.latest_candle
              klass.latest_candle.time + klass::TIME_RANGE
      Severity: Minor
      Found in app/jobs/candle_job.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language