Showing 7 of 9 total issues
Method merge_into has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def merge_into(bidasks, midpoints)
candles = bidasks.map do |bidask|
midpoint = midpoints.find {|mid| mid.time == bidask.time}
unless midpoint
Rails.logger.info "Skip because time of bidask and midpoint did not match. time: #{bidask.time}"- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method perform has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.perform(klass, params = {})
raise 'Class must be specified.' if klass.blank?
raise 'Class must be some candle-ish.' unless klass.include?(CandleConcern)
params = params.with_indifferent_accessMethod gimme_candle has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
def gimme_candle(start:, count:)
start = convert_time(start)
count ||= 100
unless count.between?(1, 5000)
message = 'The value specified is not in the valid range: ' \Method perform has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def self.perform(klass, params = {})
raise 'Class must be specified.' if klass.blank?
raise 'Class must be some candle-ish.' unless klass.include?(CandleConcern)
params = params.with_indifferent_access- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method before_enqueue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def self.before_enqueue(params = {})
params = params.with_indifferent_access
jobs = JobUtils.peek(@queue, 0, 100)
jobs.each do |job|
next if job['class'] != name- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method arrange_params has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def self.arrange_params(klass, params)
start = if params[:start]
params[:start].to_time
elsif klass.latest_candle
klass.latest_candle.time + klass::TIME_RANGE- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method save_numerous_candles has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def save_numerous_candles(start:, finish:, count:)
loop do
if start >= finish
Rails.logger.info "Exceeded finish: #{finish.in_time_zone('Asia/Tokyo')}. Finish the process."
break- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"