mizo0203/mizo-detector

View on GitHub

Showing 3 of 3 total issues

Method onLineWebhook has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private void onLineWebhook(HttpServletRequest req, HttpServletResponse resp)
      throws IOException, LineBotCallbackException {

    OfyRepository ofyRepository = new OfyRepository();
    Channel channel =
Severity: Minor
Found in src/main/java/com/mizo0203/detector/MizoDetectorServlet.java - About 1 hr to fix

    Method onLineWebhook has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      private void onLineWebhook(HttpServletRequest req, HttpServletResponse resp)
          throws IOException, LineBotCallbackException {
    
        OfyRepository ofyRepository = new OfyRepository();
        Channel channel =
    Severity: Minor
    Found in src/main/java/com/mizo0203/detector/MizoDetectorServlet.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method post has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public static void post(
          URL url, Map<String, String> reqProp, @Nonnull String body, Callback callback) {
        LOG.info("post url:     " + url);
        LOG.info("post reqProp: " + reqProp);
        LOG.info("post body:    " + body);
    Severity: Minor
    Found in src/main/java/com/mizo0203/detector/util/HttpUtil.java - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language