Sign upLogin

mizo0203/nature-remo-sample

View on GitHub
Star
app/src/main/java/com/mizo0203/natureremoapisample/data/Appliance.java

Summary

Maintainability
A
2 hrs
Test Coverage

Constructor has 9 parameters, which is greater than 7 authorized.
Open

    public Appliance(String id, DeviceCore device, ApplianceModel model, String nickname, String image, String type, AirConParams settings, AirCon aircon, Signal[] signals) {
Severity: Major
Found in app/src/main/java/com/mizo0203/natureremoapisample/data/Appliance.java by sonar-java

A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

Noncompliant Code Example

With a maximum number of 4 parameters:

public void doSomething(int param1, int param2, int param3, String param4, long param5) {
...
}

Compliant Solution

public void doSomething(int param1, int param2, int param3, String param4) {
...
}

Exceptions

Methods annotated with :

  • Spring's @RequestMapping (and related shortcut annotations, like @GetRequest)
  • JAX-RS API annotations (like @javax.ws.rs.GET)
  • Bean constructor injection with @org.springframework.beans.factory.annotation.Autowired
  • CDI constructor injection with @javax.inject.Inject
  • @com.fasterxml.jackson.annotation.JsonCreator

may have a lot of parameters, encapsulation being possible. Such methods are therefore ignored.

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static class AirConParams {
        public final String temp;
        public final String mode;
        public final String vol;
        public final String dir;
Severity: Major
Found in app/src/main/java/com/mizo0203/natureremoapisample/data/Appliance.java and 1 other location - About 1 hr to fix
app/src/main/java/com/mizo0203/natureremoapisample/data/Appliance.java on lines 63..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static class ApplianceModel {
        public final String id;
        public final String manufacturer;
        public final String remote_name;
        public final String name;
Severity: Major
Found in app/src/main/java/com/mizo0203/natureremoapisample/data/Appliance.java and 1 other location - About 1 hr to fix
app/src/main/java/com/mizo0203/natureremoapisample/data/Appliance.java on lines 79..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status