mkreiser/ESPN-Fantasy-Football-API

View on GitHub

Showing 5 of 36 total issues

File constants.js has 269 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import _ from 'lodash';

/**
 * Maps `slotCategoryId`'s numerical enum to readable positions.
 * @type {object}
Severity: Minor
Found in src/constants.js - About 2 hrs to fix

    Function getDraftInfo has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      getDraftInfo({ seasonId, scoringPeriodId = 0 }) {
        this.constructor._validateV3Params(seasonId, 'getDraftInfo');
    
        const draftRoute = this.constructor._buildRoute({
          base: `${seasonId}/segments/0/leagues/${this.leagueId}`,
    Severity: Minor
    Found in src/client/client.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const route = this.constructor._buildRoute({
            base: `${this.leagueId}`,
            params: `?scoringPeriodId=${scoringPeriodId}&seasonId=${seasonId}` +
              '&view=mMatchupScore&view=mScoreboard&view=mSettings&view=mTopPerformers&view=mTeam&view=mRoster'
          });
      Severity: Major
      Found in src/client/client.js and 1 other location - About 1 hr to fix
      src/client/client.js on lines 166..170

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const route = this.constructor._buildRoute({
            base: `${this.leagueId}`,
            params: `?scoringPeriodId=${scoringPeriodId}&seasonId=${seasonId}` +
              '&view=mMatchupScore&view=mScoreboard&view=mSettings&view=mTopPerformers&view=mTeam'
          });
      Severity: Major
      Found in src/client/client.js and 1 other location - About 1 hr to fix
      src/client/client.js on lines 272..276

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function getFreeAgents has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        getFreeAgents({ seasonId, scoringPeriodId }) {
          this.constructor._validateV3Params(seasonId, 'getFreeAgents');
      
          const route = this.constructor._buildRoute({
            base: `${seasonId}/segments/0/leagues/${this.leagueId}`,
      Severity: Minor
      Found in src/client/client.js - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language