Sign upLogin

mlaccetti/JavaPNS

View on GitHub
Star

Showing 107 of 107 total issues

Method test_Issue102 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  private static void test_Issue102(final String keystore, final String password, String token, final boolean production) {
    try {
      System.out.println("");
      System.out.println("TESTING ISSUE #102");
      final int devices = 10000;
Severity: Minor
Found in src/test/java/javapns/test/SpecificNotificationTests.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  public void addCustomDictionary(final String name, final String value) throws JSONException {
    logger.debug(ADDING_CUSTOM_DICTIONARY + name + DELIMITER_START + value + DELIMITED_END);
    put(name, value, payload, false);
  }
Severity: Minor
Found in src/main/java/javapns/notification/Payload.java and 2 other locations - About 30 mins to fix
src/main/java/javapns/notification/Payload.java on lines 91..94
src/main/java/javapns/notification/Payload.java on lines 115..118

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  public void addCustomDictionary(final String name, final Object value) throws JSONException {
    logger.debug(ADDING_CUSTOM_DICTIONARY + name + DELIMITER_START + value + DELIMITED_END);
    put(name, value, payload, false);
  }
Severity: Minor
Found in src/main/java/javapns/notification/Payload.java and 2 other locations - About 30 mins to fix
src/main/java/javapns/notification/Payload.java on lines 79..82
src/main/java/javapns/notification/Payload.java on lines 91..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  public void addCustomDictionary(final String name, final int value) throws JSONException {
    logger.debug(ADDING_CUSTOM_DICTIONARY + name + DELIMITER_START + value + DELIMITED_END);
    put(name, value, payload, false);
  }
Severity: Minor
Found in src/main/java/javapns/notification/Payload.java and 2 other locations - About 30 mins to fix
src/main/java/javapns/notification/Payload.java on lines 79..82
src/main/java/javapns/notification/Payload.java on lines 115..118

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

        return prefix + "None (unknown)";
Severity: Major
Found in src/main/java/javapns/notification/ResponsePacket.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return null;
    Severity: Major
    Found in src/main/java/javapns/notification/ResponsePacketReader.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return list;
      Severity: Major
      Found in src/main/java/javapns/devices/Devices.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return;
        Severity: Major
        Found in src/main/java/javapns/communication/KeystoreManager.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return null;
          Severity: Major
          Found in src/main/java/javapns/notification/ResponsePacketReader.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return prefix + "Undocumented status code: " + status;
            Severity: Major
            Found in src/main/java/javapns/notification/ResponsePacket.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return prefix + "Invalid token";
              Severity: Major
              Found in src/main/java/javapns/notification/ResponsePacket.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                    return list;
                Severity: Major
                Found in src/main/java/javapns/devices/Devices.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return prefix + "Invalid payload size";
                  Severity: Major
                  Found in src/main/java/javapns/notification/ResponsePacket.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                        return "APNS: Undocumented response command: " + command;
                    Severity: Major
                    Found in src/main/java/javapns/notification/ResponsePacket.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return new WrappedKeystore((KeyStore) keystore);
                      Severity: Major
                      Found in src/main/java/javapns/communication/KeystoreManager.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return prefix + "Invalid token size";
                        Severity: Major
                        Found in src/main/java/javapns/notification/ResponsePacket.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return prefix + "Invalid topic size";
                          Severity: Major
                          Found in src/main/java/javapns/notification/ResponsePacket.java - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                    return prefix + "Missing payload";
                            Severity: Major
                            Found in src/main/java/javapns/notification/ResponsePacket.java - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                  return new ResponsePacket(command, status, identifier);
                              Severity: Major
                              Found in src/main/java/javapns/notification/ResponsePacketReader.java - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                        return (InputStream) keystore;
                                Severity: Major
                                Found in src/main/java/javapns/communication/KeystoreManager.java - About 30 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language