src/main/java/javapns/notification/ResponsePacketReader.java
Method readResponsePacketData has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
private static ResponsePacket readResponsePacketData(final InputStream input) throws IOException {
final int command = input.read();
if (command < 0) {
return null;
}Method readResponses has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
private static List<ResponsePacket> readResponses(final Socket socket) {
final List<ResponsePacket> responses = new ArrayList<>();
int previousTimeout = 0;
try {
/* Set socket timeout to avoid getting stuck on read() */- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
Open
return null;Avoid too many return statements within this method. Open
Open
return null;Avoid too many return statements within this method. Open
Open
return new ResponsePacket(command, status, identifier);Method readResponsePacketData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
private static ResponsePacket readResponsePacketData(final InputStream input) throws IOException {
final int command = input.read();
if (command < 0) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"