Sign upLogin

mobi/telephone_number

View on GitHub
Star
lib/importers/phone_data_importer.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method load_formats has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def load_formats(country_data, territory)
      formats_arr = territory.css('availableFormats numberFormat').map do |format|
        {}.tap do |fhash|
          format.attributes.values.each do |attr|
            key = underscore(attr.name).to_sym
Severity: Minor
Found in lib/importers/phone_data_importer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load_validations has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def load_validations(country_data, territory)
      country_data[:validations] = {}
      territory.elements.each do |element|
        next if element.name == 'references' || element.name == 'availableFormats'
        country_data[:validations][underscore(element.name).to_sym] = {}.tap do |validation_hash|
Severity: Minor
Found in lib/importers/phone_data_importer.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status