modxcms/revolution

View on GitHub
core/model/aws/services/as.class.php

Summary

Maintainability
F
4 days
Test Coverage

File as.class.php has 314 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * Copyright 2010-2011 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License").
Severity: Minor
Found in core/model/aws/services/as.class.php - About 3 hrs to fix

    AmazonAS has 28 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class AmazonAS extends CFRuntime
    {
    
        /*%******************************************************************************************%*/
        // CLASS CONSTANTS
    Severity: Minor
    Found in core/model/aws/services/as.class.php - About 3 hrs to fix

      Method create_launch_configuration has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function create_launch_configuration($launch_configuration_name, $image_id, $instance_type, $opt = null)
          {
              if (!$opt) $opt = array();
              $opt['LaunchConfigurationName'] = $launch_configuration_name;
              $opt['ImageId'] = $image_id;
      Severity: Minor
      Found in core/model/aws/services/as.class.php - About 1 hr to fix

        Method create_auto_scaling_group has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function create_auto_scaling_group($auto_scaling_group_name, $launch_configuration_name, $min_size, $max_size, $availability_zones, $opt = null)
        Severity: Minor
        Found in core/model/aws/services/as.class.php - About 45 mins to fix

          Method put_scaling_policy has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function put_scaling_policy($auto_scaling_group_name, $policy_name, $scaling_adjustment, $adjustment_type, $opt = null)
          Severity: Minor
          Found in core/model/aws/services/as.class.php - About 35 mins to fix

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                public function resume_processes($auto_scaling_group_name, $opt = null)
                {
                    if (!$opt) $opt = array();
                    $opt['AutoScalingGroupName'] = $auto_scaling_group_name;
            
            
            Severity: Major
            Found in core/model/aws/services/as.class.php and 4 other locations - About 2 hrs to fix
            core/model/aws/services/as.class.php on lines 702..717
            core/model/aws/services/as.class.php on lines 781..796
            core/model/aws/services/as.class.php on lines 907..922
            core/model/aws/services/rds.class.php on lines 402..417

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 140.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                public function update_auto_scaling_group($auto_scaling_group_name, $opt = null)
                {
                    if (!$opt) $opt = array();
                    $opt['AutoScalingGroupName'] = $auto_scaling_group_name;
            
            
            Severity: Major
            Found in core/model/aws/services/as.class.php and 4 other locations - About 2 hrs to fix
            core/model/aws/services/as.class.php on lines 781..796
            core/model/aws/services/as.class.php on lines 809..824
            core/model/aws/services/as.class.php on lines 907..922
            core/model/aws/services/rds.class.php on lines 402..417

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 140.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                public function suspend_processes($auto_scaling_group_name, $opt = null)
                {
                    if (!$opt) $opt = array();
                    $opt['AutoScalingGroupName'] = $auto_scaling_group_name;
            
            
            Severity: Major
            Found in core/model/aws/services/as.class.php and 4 other locations - About 2 hrs to fix
            core/model/aws/services/as.class.php on lines 702..717
            core/model/aws/services/as.class.php on lines 809..824
            core/model/aws/services/as.class.php on lines 907..922
            core/model/aws/services/rds.class.php on lines 402..417

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 140.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                public function disable_metrics_collection($auto_scaling_group_name, $opt = null)
                {
                    if (!$opt) $opt = array();
                    $opt['AutoScalingGroupName'] = $auto_scaling_group_name;
            
            
            Severity: Major
            Found in core/model/aws/services/as.class.php and 4 other locations - About 2 hrs to fix
            core/model/aws/services/as.class.php on lines 702..717
            core/model/aws/services/as.class.php on lines 781..796
            core/model/aws/services/as.class.php on lines 809..824
            core/model/aws/services/rds.class.php on lines 402..417

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 140.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 10 locations. Consider refactoring.
            Open

                public function describe_auto_scaling_groups($opt = null)
                {
                    if (!$opt) $opt = array();
            
                    // Optional parameter
            Severity: Major
            Found in core/model/aws/services/as.class.php and 9 other locations - About 2 hrs to fix
            core/model/aws/services/as.class.php on lines 262..276
            core/model/aws/services/as.class.php on lines 401..415
            core/model/aws/services/as.class.php on lines 467..481
            core/model/aws/services/as.class.php on lines 586..600
            core/model/aws/services/cloudformation.class.php on lines 159..173
            core/model/aws/services/cloudwatch.class.php on lines 439..453
            core/model/aws/services/elasticbeanstalk.class.php on lines 367..381
            core/model/aws/services/elasticbeanstalk.class.php on lines 920..934
            core/model/aws/services/elb.class.php on lines 340..354

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 125.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 10 locations. Consider refactoring.
            Open

                public function describe_auto_scaling_instances($opt = null)
                {
                    if (!$opt) $opt = array();
            
                    // Optional parameter
            Severity: Major
            Found in core/model/aws/services/as.class.php and 9 other locations - About 2 hrs to fix
            core/model/aws/services/as.class.php on lines 262..276
            core/model/aws/services/as.class.php on lines 310..324
            core/model/aws/services/as.class.php on lines 401..415
            core/model/aws/services/as.class.php on lines 467..481
            core/model/aws/services/cloudformation.class.php on lines 159..173
            core/model/aws/services/cloudwatch.class.php on lines 439..453
            core/model/aws/services/elasticbeanstalk.class.php on lines 367..381
            core/model/aws/services/elasticbeanstalk.class.php on lines 920..934
            core/model/aws/services/elb.class.php on lines 340..354

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 125.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 10 locations. Consider refactoring.
            Open

                public function describe_policies($opt = null)
                {
                    if (!$opt) $opt = array();
            
                    // Optional parameter
            Severity: Major
            Found in core/model/aws/services/as.class.php and 9 other locations - About 2 hrs to fix
            core/model/aws/services/as.class.php on lines 262..276
            core/model/aws/services/as.class.php on lines 310..324
            core/model/aws/services/as.class.php on lines 401..415
            core/model/aws/services/as.class.php on lines 586..600
            core/model/aws/services/cloudformation.class.php on lines 159..173
            core/model/aws/services/cloudwatch.class.php on lines 439..453
            core/model/aws/services/elasticbeanstalk.class.php on lines 367..381
            core/model/aws/services/elasticbeanstalk.class.php on lines 920..934
            core/model/aws/services/elb.class.php on lines 340..354

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 125.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 10 locations. Consider refactoring.
            Open

                public function describe_launch_configurations($opt = null)
                {
                    if (!$opt) $opt = array();
            
                    // Optional parameter
            Severity: Major
            Found in core/model/aws/services/as.class.php and 9 other locations - About 2 hrs to fix
            core/model/aws/services/as.class.php on lines 310..324
            core/model/aws/services/as.class.php on lines 401..415
            core/model/aws/services/as.class.php on lines 467..481
            core/model/aws/services/as.class.php on lines 586..600
            core/model/aws/services/cloudformation.class.php on lines 159..173
            core/model/aws/services/cloudwatch.class.php on lines 439..453
            core/model/aws/services/elasticbeanstalk.class.php on lines 367..381
            core/model/aws/services/elasticbeanstalk.class.php on lines 920..934
            core/model/aws/services/elb.class.php on lines 340..354

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 125.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 10 locations. Consider refactoring.
            Open

                public function describe_scaling_activities($opt = null)
                {
                    if (!$opt) $opt = array();
            
                    // Optional parameter
            Severity: Major
            Found in core/model/aws/services/as.class.php and 9 other locations - About 2 hrs to fix
            core/model/aws/services/as.class.php on lines 262..276
            core/model/aws/services/as.class.php on lines 310..324
            core/model/aws/services/as.class.php on lines 467..481
            core/model/aws/services/as.class.php on lines 586..600
            core/model/aws/services/cloudformation.class.php on lines 159..173
            core/model/aws/services/cloudwatch.class.php on lines 439..453
            core/model/aws/services/elasticbeanstalk.class.php on lines 367..381
            core/model/aws/services/elasticbeanstalk.class.php on lines 920..934
            core/model/aws/services/elb.class.php on lines 340..354

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 125.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 13 locations. Consider refactoring.
            Open

                public function __construct($key = null, $secret_key = null)
                {
                    $this->api_version = '2010-08-01';
                    $this->hostname = self::DEFAULT_URL;
            
            
            Severity: Major
            Found in core/model/aws/services/as.class.php and 12 other locations - About 1 hr to fix
            core/model/aws/services/cloudformation.class.php on lines 120..140
            core/model/aws/services/cloudwatch.class.php on lines 119..139
            core/model/aws/services/elasticache.class.php on lines 78..98
            core/model/aws/services/elasticbeanstalk.class.php on lines 87..107
            core/model/aws/services/elb.class.php on lines 93..113
            core/model/aws/services/emr.class.php on lines 95..115
            core/model/aws/services/iam.class.php on lines 64..84
            core/model/aws/services/importexport.class.php on lines 54..74
            core/model/aws/services/rds.class.php on lines 99..119
            core/model/aws/services/sdb.class.php on lines 222..242
            core/model/aws/services/ses.class.php on lines 85..105
            core/model/aws/services/sts.class.php on lines 68..88

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 118.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                public function put_scaling_policy($auto_scaling_group_name, $policy_name, $scaling_adjustment, $adjustment_type, $opt = null)
                {
                    if (!$opt) $opt = array();
                    $opt['AutoScalingGroupName'] = $auto_scaling_group_name;
                    $opt['PolicyName'] = $policy_name;
            Severity: Major
            Found in core/model/aws/services/as.class.php and 3 other locations - About 1 hr to fix
            core/model/aws/services/iam.class.php on lines 612..621
            core/model/aws/services/iam.class.php on lines 999..1008
            core/model/aws/services/importexport.class.php on lines 178..187

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status