Sign upLogin

modxcms/revolution

View on GitHub
Star
core/model/aws/services/cloudformation.class.php

Summary

Maintainability
B
4 hrs
Test Coverage

Similar blocks of code found in 10 locations. Consider refactoring.
Open

    public function list_stacks($opt = null)
    {
        if (!$opt) $opt = array();

        // Optional parameter
Severity: Major
Found in core/model/aws/services/cloudformation.class.php and 9 other locations - About 2 hrs to fix
core/model/aws/services/as.class.php on lines 262..276
core/model/aws/services/as.class.php on lines 310..324
core/model/aws/services/as.class.php on lines 401..415
core/model/aws/services/as.class.php on lines 467..481
core/model/aws/services/as.class.php on lines 586..600
core/model/aws/services/cloudwatch.class.php on lines 439..453
core/model/aws/services/elasticbeanstalk.class.php on lines 367..381
core/model/aws/services/elasticbeanstalk.class.php on lines 920..934
core/model/aws/services/elb.class.php on lines 340..354

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

    public function __construct($key = null, $secret_key = null)
    {
        $this->api_version = '2010-05-15';
        $this->hostname = self::DEFAULT_URL;
Severity: Major
Found in core/model/aws/services/cloudformation.class.php and 12 other locations - About 1 hr to fix
core/model/aws/services/as.class.php on lines 110..130
core/model/aws/services/cloudwatch.class.php on lines 119..139
core/model/aws/services/elasticache.class.php on lines 78..98
core/model/aws/services/elasticbeanstalk.class.php on lines 87..107
core/model/aws/services/elb.class.php on lines 93..113
core/model/aws/services/emr.class.php on lines 95..115
core/model/aws/services/iam.class.php on lines 64..84
core/model/aws/services/importexport.class.php on lines 54..74
core/model/aws/services/rds.class.php on lines 99..119
core/model/aws/services/sdb.class.php on lines 222..242
core/model/aws/services/ses.class.php on lines 85..105
core/model/aws/services/sts.class.php on lines 68..88

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status