Sign upLogin

modxcms/revolution

View on GitHub
Star
core/model/aws/services/cloudfront.class.php

Summary

Maintainability
F
1 wk
Test Coverage

File cloudfront.class.php has 699 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * Copyright 2010-2011 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License").
Severity: Major
Found in core/model/aws/services/cloudfront.class.php - About 1 day to fix

    Function update_config_xml has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
    Open

        public function update_config_xml($xml, $opt = null)
    {
        // If we receive a full CFResponse object, only use the body.
        if ($xml instanceof CFResponse)
        {
    Severity: Minor
    Found in core/model/aws/services/cloudfront.class.php - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update_config_xml has 123 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function update_config_xml($xml, $opt = null)
    {
        // If we receive a full CFResponse object, only use the body.
        if ($xml instanceof CFResponse)
        {
    Severity: Major
    Found in core/model/aws/services/cloudfront.class.php - About 4 hrs to fix

      Function generate_config_xml has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
      Open

          public function generate_config_xml($origin, $caller_reference, $opt = null)
    {
        // Default, empty XML
        $xml = simplexml_load_string(sprintf($this->base_xml, (
            (isset($opt['Streaming']) && $opt['Streaming'] == (bool) true) ? 'StreamingDistributionConfig' : 'DistributionConfig')
      Severity: Minor
      Found in core/model/aws/services/cloudfront.class.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function remove_cname has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
      Open

          public function remove_cname($xml, $cname)
    {
        // If we receive a full CFResponse object, only use the body.
        if ($xml instanceof CFResponse)
        {
      Severity: Minor
      Found in core/model/aws/services/cloudfront.class.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      AmazonCloudFront has 31 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class AmazonCloudFront extends CFRuntime
{
    /**
     * Specify the default queue URL.
     */
      Severity: Minor
      Found in core/model/aws/services/cloudfront.class.php - About 3 hrs to fix

        Method authenticate has 94 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function authenticate($method = 'GET', $path = null, $opt = null, $xml = null, $etag = null, $redirects = 0)
    {
        if (!$opt) $opt = array();
        $querystring = null;
        Severity: Major
        Found in core/model/aws/services/cloudfront.class.php - About 3 hrs to fix

          Method generate_config_xml has 93 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function generate_config_xml($origin, $caller_reference, $opt = null)
    {
        // Default, empty XML
        $xml = simplexml_load_string(sprintf($this->base_xml, (
            (isset($opt['Streaming']) && $opt['Streaming'] == (bool) true) ? 'StreamingDistributionConfig' : 'DistributionConfig')
          Severity: Major
          Found in core/model/aws/services/cloudfront.class.php - About 3 hrs to fix

            Function authenticate has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
            Open

                public function authenticate($method = 'GET', $path = null, $opt = null, $xml = null, $etag = null, $redirects = 0)
    {
        if (!$opt) $opt = array();
        $querystring = null;
            Severity: Minor
            Found in core/model/aws/services/cloudfront.class.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method get_private_object_url has 66 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function get_private_object_url($distribution_hostname, $filename, $expires, $opt = null)
    {
        if (!$this->key_pair_id || !$this->private_key)
        {
            throw new CloudFront_Exception('You must set both a Amazon CloudFront keypair ID and an RSA private key for that keypair before using ' . __FUNCTION__ . '()');
            Severity: Major
            Found in core/model/aws/services/cloudfront.class.php - About 2 hrs to fix

              Method remove_cname has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function remove_cname($xml, $cname)
    {
        // If we receive a full CFResponse object, only use the body.
        if ($xml instanceof CFResponse)
        {
              Severity: Minor
              Found in core/model/aws/services/cloudfront.class.php - About 1 hr to fix

                Function get_private_object_url has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function get_private_object_url($distribution_hostname, $filename, $expires, $opt = null)
    {
        if (!$this->key_pair_id || !$this->private_key)
        {
            throw new CloudFront_Exception('You must set both a Amazon CloudFront keypair ID and an RSA private key for that keypair before using ' . __FUNCTION__ . '()');
                Severity: Minor
                Found in core/model/aws/services/cloudfront.class.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method authenticate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function authenticate($method = 'GET', $path = null, $opt = null, $xml = null, $etag = null, $redirects = 0)
                Severity: Minor
                Found in core/model/aws/services/cloudfront.class.php - About 45 mins to fix

                  Method cache_callback has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function cache_callback($method = 'GET', $path = null, $opt = null, $xml = null, $etag = null)
                  Severity: Minor
                  Found in core/model/aws/services/cloudfront.class.php - About 35 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return $data;
                    Severity: Major
                    Found in core/model/aws/services/cloudfront.class.php - About 30 mins to fix

                      Function __construct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function __construct($key = null, $secret_key = null)
    {
        $this->api_version = '2010-11-01';
        $this->hostname = self::DEFAULT_URL;
                      Severity: Minor
                      Found in core/model/aws/services/cloudfront.class.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if (isset($opt['Logging']))
        {
            if (is_array($opt['Logging']))
            {
                $logging = $update->addChild('Logging');
                      Severity: Major
                      Found in core/model/aws/services/cloudfront.class.php and 1 other location - About 1 hr to fix
                      core/model/aws/services/cloudfront.class.php on lines 449..463

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 104.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if (isset($opt['Logging']))
        {
            if (is_array($opt['Logging']))
            {
                $logging = $xml->addChild('Logging');
                      Severity: Major
                      Found in core/model/aws/services/cloudfront.class.php and 1 other location - About 1 hr to fix
                      core/model/aws/services/cloudfront.class.php on lines 615..633

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 104.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if (isset($opt['TrustedSigners']))
        {
            $trusted_signers = $xml->addChild('TrustedSigners');

            // Not an array? Convert to one.
                      Severity: Major
                      Found in core/model/aws/services/cloudfront.class.php and 1 other location - About 1 hr to fix
                      core/model/aws/services/cloudfront.class.php on lines 636..675

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 101.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if (isset($opt['TrustedSigners']))
        {
            $trusted_signers = $update->addChild('TrustedSigners');

            // Not an array? Convert to one.
                      Severity: Major
                      Found in core/model/aws/services/cloudfront.class.php and 1 other location - About 1 hr to fix
                      core/model/aws/services/cloudfront.class.php on lines 473..495

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 101.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status